Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIDATIMP-1666: Display correctly Percentage and Currency fields for orders and invoices #1630

Merged
merged 20 commits into from
Oct 11, 2024
Merged

UIDATIMP-1666: Display correctly Percentage and Currency fields for orders and invoices #1630

merged 20 commits into from
Oct 11, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Sometimes we get percentage and currency types in format percentage or Percentage.

Approach

  • Added .toLowerCase() for amountType.
  • Added unique id for Donor information accordion.

Refs

UIDATIMP-1666

Screenshots

OleksandrHladchenko1 and others added 18 commits March 8, 2024 14:18
@OleksandrHladchenko1
UIDATIMP-1598: Remove MARC Bib option when Action = Create and update…
0b480b7 
… translation for 'Create' option
@OleksandrHladchenko1
Merge branch 'master' into UIDATIMP-1598
cf96ccd
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
c9f8931
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
bcdba95
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
c185ad8
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
1167175
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
0364eba
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
b0a57c6
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
11e981f
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
fda4066
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
9e35530
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
e098721
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
ba065b3
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
042af77
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
5e8587a
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
2659af7
@OleksandrHladchenko1
Merge branch 'master' of https://github.com/folio-org/ui-data-import
afa15d7
@OleksandrHladchenko1
UIDATIMP-1666: Display correctly 'Percentage' and 'currency' fields f…
7ce1d20 
…or orders and invoices + add unique id for 'Donor information' accordion
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     225 suites  ±0   11m 0s ⏱️ -1s
1 256 tests ±0  1 251 ✔️ ±0  5 💤 ±0  0 ❌ ±0 
1 267 runs  ±0  1 262 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 3eb0b9b. ± Comparison against base commit fead5b5.

♻️ This comment has been updated with latest results.

@mariia-aloshyna mariia-aloshyna requested a review from a team October 10, 2024 11:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 1d5c9e4 into master Oct 11, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIDATIMP-1666 branch October 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @zburke @mariia-aloshyna