Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIDATIMP-1634: Refactor away from default props for functional components #1655

Merged
merged 2 commits into from
Nov 22, 2024
Merged

UIDATIMP-1634: Refactor away from default props for functional components #1655

merged 2 commits into from
Nov 22, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • defaultProps will be removed from function components in place of ES6 default parameters. Class components will continue to support defaultProps since there is no ES6 alternative.

Approach

  • Removed defaultProps in ViewJobProfileComponent component

Refs

UIDATIMP-1634

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     225 suites  ±0   10m 58s ⏱️ -1s
1 256 tests ±0  1 251 ✔️ ±0  5 💤 ±0  0 ❌ ±0 
1 267 runs  ±0  1 262 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit b02a81e. ± Comparison against base commit 1dc89de.

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 075cc5d into master Nov 22, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIDATIMP-1634 branch November 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vashjs vashjs vashjs approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @mariia-aloshyna @vashjs