UIDATIMP-1686: Replace _/proxy/tenants/${tenant}/modules request with stripes.discovery.modules object
#1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes.discovery.modules` object
mariia-aloshyna
force-pushed
the
UIDATIMP-1686
branch
from
c8d875b to
ecc0be5
Compare
OleksandrHladchenko1
approved these changes
Dec 4, 2024
|
mariia-aloshyna
added a commit
that referenced
this pull request
Dec 5, 2024
* UIDATIMP-1679: Allow central tenant to create action profile for Orders and Invoices (#1657) (cherry picked from commit eb823c7) * UIDATIMP-1686: Replace `_/proxy/tenants/${tenant}/modules` with `stripes.discovery.modules` object (#1661) (cherry picked from commit 9ae7e0b) * Release v8.0.3 --------- Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While troubleshooting an issue in the Eureka-bugfest environment, we ran across a bit of code in ui-data-import that queries Okapi for the tenant’s currently-installed modules with a manifest like:
_/proxy/tenants/${tenant}/modules;This same data is available on stripes at stripes.discovery.modules . The discovery process in Eureka is quite different than in legacy FOLIO, with different endpoints etc etc, but all that logic is consolidated within stripes-core at present. If we can leverage the discovery data attached to stripes instead of making a query, then we can keep it that way and avoid the need for Eureka-specific code to pollute ui-data-import.
Approach
_/proxy/tenants/${tenant}/modulesrequest in Match profiles and get data fromstripes.discovery.modulesobject.Refs
https://folio-org.atlassian.net/browse/UIDATIMP-1686
Screenshots