Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UID-162] Fence off ShowCapabilities behind IfInterface checks for capabilities, capability-sets #435

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ryandberger
Copy link
Member

  • Ensure ShowCapabilities only displays as an option when correct interfaces are present.
  • Fixes UID-162

@ryandberger ryandberger requested review from zburke and aidynoJ October 4, 2024 15:55
Copy link

sonarqubecloud bot commented Oct 4, 2024

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You changed the shape of the route; it was previously protected by the permission ui-developer.settings.configuration but is now unprotected. Was that deliberate?

Probably there should be a new permission in package.json that conveys permission to run these API queries but that can be handled separately/later.

@ryandberger
Copy link
Member Author

LGTM. You changed the shape of the route; it was previously protected by the permission ui-developer.settings.configuration but is now unprotected. Was that deliberate?

Probably there should be a new permission in package.json that conveys permission to run these API queries but that can be handled separately/later.

Yes, deliberate. It was in there as a placeholder before but it's not a matching permission. I agree that a specific permission should be added later.

@ryandberger ryandberger merged commit 7430798 into master Oct 4, 2024
14 checks passed
@ryandberger ryandberger deleted the UID-162 branch October 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants