refactor unit tests to apply multiple stores

folio-org · Dec 4, 2024 · 9e58809 · 9e58809
1 parent a8fd004
commit 9e58809
Show file tree

Hide file tree

Showing 16 changed files with 154 additions and 44 deletions.
diff --git a/src/test/__mocks__/store/index.ts b/src/test/__mocks__/store/index.ts
@@ -1,13 +1,31 @@
 import { StoreApi } from 'zustand';
 
-export const setInitialGlobalState = <T>(store: StoreApi<T>, initialState: any) =>
-  store.setState({
-    ...store.getInitialState(),
-    ...initialState,
+type StoreState = Record<string, any>;
+
+interface StoreWithState {
+  store: StoreApi<StoreState>;
+  state: StoreState;
+}
+
+interface StoreWithUpdatedState<T> {
+  store: StoreApi<T>;
+  updatedState: Partial<T>;
+}
+
+export const setInitialGlobalState = (storeWithStates: StoreWithState[]) => {
+  storeWithStates.forEach(({ store, state }) => {
+    store.setState({
+      ...store.getInitialState(),
+      ...state,
+    });
   });
+};
 
-export const setUpdatedGlobalState = <T>(store: StoreApi<T>, updatedState: any) =>
-  store.setState({
-    ...store.getState(),
-    ...updatedState,
+export const setUpdatedGlobalState = <T>(storeWithUpdatedStates: StoreWithUpdatedState<T>[]) => {
+  storeWithUpdatedStates.forEach(({ store, updatedState }) => {
+    store.setState({
+      ...store.getState(),
+      ...updatedState,
+    });
   });
+};
diff --git a/src/test/__tests__/common/hooks/useConfig.hook.test.ts b/src/test/__tests__/common/hooks/useConfig.hook.test.ts
@@ -78,7 +78,12 @@ describe('useConfig', () => {
   const setSelectedRecordBlocks = jest.fn();
 
   const mockUseRecoilState = (profiles: ProfileEntry[] = []) => {
-    setUpdatedGlobalState(useProfileStore, { profiles, preparedFields: null });
+    setUpdatedGlobalState([
+      {
+        store: useProfileStore,
+        updatedState: { profiles, preparedFields: null },
+      },
+    ]);
   };
 
   beforeEach(() => {
@@ -88,18 +93,23 @@ describe('useConfig', () => {
       .mockReturnValueOnce(setPreviewContent)
       .mockReturnValueOnce(setSelectedRecordBlocks);
 
-    setInitialGlobalState(useProfileStore, {
-      profiles: [],
-      setProfiles,
-      selectedProfile: {},
-      setSelectedProfile,
-      preparedFields: {},
-      setPreparedFields,
-      schema: {},
-      setSchema,
-      initialSchemaKey: '',
-      setInitialSchemaKey,
-    });
+    setInitialGlobalState([
+      {
+        store: useProfileStore,
+        state: {
+          profiles: [],
+          setProfiles,
+          selectedProfile: {},
+          setSelectedProfile,
+          preparedFields: {},
+          setPreparedFields,
+          schema: {},
+          setSchema,
+          initialSchemaKey: '',
+          setInitialSchemaKey,
+        },
+      },
+    ]);
 
     (SchemaService.SchemaService as jest.Mock).mockImplementation(() => ({ generate: jest.fn() }));
   });

diff --git a/src/test/__tests__/common/hooks/useContainerEvents.test.ts b/src/test/__tests__/common/hooks/useContainerEvents.test.ts
@@ -24,7 +24,12 @@ describe('useContainerEvents', () => {
     (useRecoilValue as jest.Mock).mockReturnValueOnce(false);
     (useRecoilValue as jest.Mock).mockReturnValueOnce(mockEvents);
 
-    setInitialGlobalState(useStatusStore, { isEditedRecord });
+    setInitialGlobalState([
+      {
+        store: useStatusStore,
+        state: { isEditedRecord },
+      },
+    ]);
 
     renderHook(() => useContainerEvents({ watchEditedState: true }));
   };

diff --git a/src/test/__tests__/common/hooks/useLoadSearchResults.test.ts b/src/test/__tests__/common/hooks/useLoadSearchResults.test.ts
@@ -33,7 +33,12 @@ describe('useLoadSearchResults', () => {
   const setIsLoading = jest.fn();
 
   beforeEach(() => {
-    setInitialGlobalState(useLoadingStateStore, { isLoading: false, setIsLoading });
+    setInitialGlobalState([
+      {
+        store: useLoadingStateStore,
+        state: { isLoading: false, setIsLoading },
+      },
+    ]);
   });
 
   it('fetches data and updates state with query and searchBy', async () => {

diff --git a/src/test/__tests__/common/hooks/useRecordGeneration.test.ts b/src/test/__tests__/common/hooks/useRecordGeneration.test.ts
@@ -14,8 +14,21 @@ describe('useRecordGeneration', () => {
     const selectedEntries = 'mockSelectedEntries';
     const initKey = 'mockInitialSchemaKey';
 
-    setInitialGlobalState(useProfileStore, { schema, initialSchemaKey: initKey });
-    setInitialGlobalState(useInputsStore, { userValues });
+    setInitialGlobalState([
+      {
+        store: useProfileStore,
+        state: {
+          schema,
+          initialSchemaKey: initKey,
+        },
+      },
+      {
+        store: useInputsStore,
+        state: {
+          userValues,
+        },
+      },
+    ]);
 
     (useRecoilValue as jest.Mock).mockReturnValueOnce(selectedEntries);
 

diff --git a/src/test/__tests__/common/hooks/useRecordStatus.test.ts b/src/test/__tests__/common/hooks/useRecordStatus.test.ts
@@ -11,7 +11,12 @@ jest.mock('react-router-dom');
 describe('useRecordStatus', () => {
   const renderUseRecordStatusHook = (lastSavedIdEqual = false) => {
     (useParams as jest.Mock).mockReturnValueOnce({ resourceId: mockResourceId });
-    setInitialGlobalState(useStatusStore, { lastSavedRecordId: lastSavedIdEqual ? mockResourceId : 'anotherId' });
+    setInitialGlobalState([
+      {
+        store: useStatusStore,
+        state: { lastSavedRecordId: lastSavedIdEqual ? mockResourceId : 'anotherId' },
+      },
+    ]);
 
     const {
       result: { current },

diff --git a/src/test/__tests__/common/hooks/useSearch.test.ts b/src/test/__tests__/common/hooks/useSearch.test.ts
@@ -80,7 +80,12 @@ describe('useSearch hook', () => {
   };
 
   beforeEach(() => {
-    setInitialGlobalState(useLoadingStateStore, { isLoading: false, setIsLoading });
+    setInitialGlobalState([
+      {
+        store: useLoadingStateStore,
+        state: { isLoading: false, setIsLoading },
+      },
+    ]);
     (useSearchContext as jest.Mock).mockReturnValue(mockUseSearchContext);
     (useSearchParams as jest.Mock).mockReturnValue([null, setSearchParams]);
 

diff --git a/src/test/__tests__/components/CommonStatus.test.tsx b/src/test/__tests__/components/CommonStatus.test.tsx
@@ -6,7 +6,12 @@ import { setInitialGlobalState } from '@src/test/__mocks__/store';
 
 describe('CommonStatus', () => {
   const renderComponent = (statusMessages: StatusEntry[] = []) => {
-    setInitialGlobalState(useStatusStore, { statusMessages });
+    setInitialGlobalState([
+      {
+        store: useStatusStore,
+        state: { statusMessages },
+      },
+    ]);
 
     return render(<CommonStatus />);
   };

diff --git a/src/test/__tests__/components/ComplexLookupField/ComplexLookupField.test.tsx b/src/test/__tests__/components/ComplexLookupField/ComplexLookupField.test.tsx
@@ -31,7 +31,12 @@ describe('Complex Lookup Field', () => {
   const { getByTestId, getAllByTestId, queryByTestId, queryAllByTestId, getByRole } = screen;
 
   function renderComponent(entry: SchemaEntry = {} as SchemaEntry, value: UserValueContents[] = []) {
-    setInitialGlobalState(useProfileStore, { schema: {} as Schema });
+    setInitialGlobalState([
+      {
+        store: useProfileStore,
+        state: { schema: {} as Schema },
+      },
+    ]);
 
     render(
       <RecoilRoot

diff --git a/src/test/__tests__/components/EditSection.test.tsx b/src/test/__tests__/components/EditSection.test.tsx
@@ -188,14 +188,20 @@ jest.mock('@common/constants/build.constants', () => ({ IS_EMBEDDED_MODE: false
 
 describe('EditSection', () => {
   const renderScreen = () => {
-    setInitialGlobalState(useProfileStore, {
-      selectedProfile: monograph as unknown as ProfileEntry,
-      initialSchemaKey: 'uuid0',
-      schema: schema as Schema,
-    });
-    setInitialGlobalState(useInputsStore, {
-      userValues,
-    });
+    setInitialGlobalState([
+      {
+        store: useProfileStore,
+        state: {
+          selectedProfile: monograph as unknown as ProfileEntry,
+          initialSchemaKey: 'uuid0',
+          schema: schema as Schema,
+        },
+      },
+      {
+        store: useInputsStore,
+        state: { userValues },
+      },
+    ]);
 
     return render(
       <RecoilRoot

diff --git a/src/test/__tests__/components/MarcPreviewComplexLookup.test.tsx b/src/test/__tests__/components/MarcPreviewComplexLookup.test.tsx
@@ -35,7 +35,12 @@ describe('MarcPreviewComplexLookup', () => {
     marcPreviewData: MarcDTO,
     marcPreviewMetadata: MarcPreviewMetadata,
   ) => {
-    setInitialGlobalState(useMarcPreviewStore, { complexValue: marcPreviewData, metaData: marcPreviewMetadata });
+    setInitialGlobalState([
+      {
+        store: useMarcPreviewStore,
+        state: { complexValue: marcPreviewData, metaData: marcPreviewMetadata },
+      },
+    ]);
 
     return render(
       <RecoilRoot

diff --git a/src/test/__tests__/components/Preview.test.tsx b/src/test/__tests__/components/Preview.test.tsx
@@ -41,8 +41,16 @@ describe('Preview', () => {
   const { getAllByTestId, getByText } = screen;
 
   beforeEach(() => {
-    setInitialGlobalState(useProfileStore, { initialSchemaKey, schema });
-    setInitialGlobalState(useInputsStore, { userValues });
+    setInitialGlobalState([
+      {
+        store: useProfileStore,
+        state: { initialSchemaKey, schema },
+      },
+      {
+        store: useInputsStore,
+        state: { userValues },
+      },
+    ]);
 
     return render(
       <RecoilRoot

diff --git a/src/test/__tests__/components/SaveRecord.test.tsx b/src/test/__tests__/components/SaveRecord.test.tsx
@@ -8,7 +8,12 @@ import { setInitialGlobalState } from '@src/test/__mocks__/store';
 
 describe('SaveRecord', () => {
   function renderSaveRecordComponent(isEditedRecord = true) {
-    setInitialGlobalState(useStatusStore, { isEditedRecord });
+    setInitialGlobalState([
+      {
+        store: useStatusStore,
+        state: { isEditedRecord },
+      },
+    ]);
 
     render(
       <RecoilRoot>

diff --git a/src/test/__tests__/components/ViewMarcModal.test.tsx b/src/test/__tests__/components/ViewMarcModal.test.tsx
@@ -35,7 +35,12 @@ const mockMarcPreview = {
 
 describe('ViewMarcModal', () => {
   test('renders modal and its contents', async () => {
-    setInitialGlobalState(useMarcPreviewStore, { basicValue: mockMarcPreview });
+    setInitialGlobalState([
+      {
+        store: useMarcPreviewStore,
+        state: { basicValue: mockMarcPreview },
+      },
+    ]);
 
     const { findByText } = render(<ViewMarcModal />);
 

diff --git a/src/test/__tests__/views/Edit.test.tsx b/src/test/__tests__/views/Edit.test.tsx
@@ -50,7 +50,12 @@ describe('Edit', () => {
 
   const renderComponent = (recordState: ProfileEntry | null) =>
     act(async () => {
-      setInitialGlobalState(useProfileStore, { selectedProfile: recordState });
+      setInitialGlobalState([
+        {
+          store: useProfileStore,
+          state: { selectedProfile: recordState },
+        },
+      ]);
 
       return render(
         <RecoilRoot>

diff --git a/src/test/__tests__/views/Root.test.tsx b/src/test/__tests__/views/Root.test.tsx
@@ -13,7 +13,12 @@ useRoutePathPattern.mockImplementation(() => null);
 
 describe('Root', () => {
   function renderRootComponent(isLoading = false) {
-    setInitialGlobalState(useLoadingStateStore, { isLoading });
+    setInitialGlobalState([
+      {
+        store: useLoadingStateStore,
+        state: { isLoading },
+      },
+    ]);
 
     render(
       <RecoilRoot>