UILD-427: Authority validation - Creator of Work #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/UILD-427-authority-validation
SKarolFolio
requested review from
AndreiBordak,
s3fs,
pkjacob,
PBobylev and
askhat-abishev
s3fs
approved these changes
Dec 20, 2024
AndreiBordak
approved these changes
Dec 20, 2024
|
pkjacob
reviewed
Dec 20, 2024
| "ld.rdPropertiesMatchContinue": "Properties of this resource match an existing resource. Do you want to continue?" | ||
| "ld.rdPropertiesMatchContinue": "Properties of this resource match an existing resource. Do you want to continue?", | ||
| "ld.errorMakingApiRequest": "Error making API request", | ||
| "ld.errorValidatingAuthorityRecord": "Error validating authority record" |
There was a problem hiding this comment.
I think it is better to give a more meaningful error here indicating that the selected authority is not valid for the property. We can discuss with Doug on Monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/UILD-427