refactor: move logic to constant

folio-org · Oct 6, 2023 · f3b4596 · f3b4596
1 parent dbc907c
commit f3b4596
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/components/PurchaseOrder/OngoingOrderInfo/OngoingInfoForm.js b/src/components/PurchaseOrder/OngoingOrderInfo/OngoingInfoForm.js
@@ -35,6 +35,7 @@ const OngoingInfoForm = ({ hiddenFields = {} }) => {
   const isSubscription = !!ongoingFormValues?.isSubscription;
   const isClosedNonInteractive = values.workflowStatus && isWorkflowStatusClosed(values);
   const isNonPendingNonInteractive = values.workflowStatus && !isWorkflowStatusIsPending(values);
+  const isOpenNonInteractive = values.workflowStatus && !isWorkflowStatusOpen(values);
 
   if (isClosedNonInteractive && disabled) return null;
 
@@ -52,7 +53,7 @@ const OngoingInfoForm = ({ hiddenFields = {} }) => {
             <VisibilityControl name="hiddenFields.ongoing.isSubscription">
               <FieldRenewalSubscription
                 disabled={disabled}
-                isNonInteractive={isNonPendingNonInteractive && !isWorkflowStatusOpen(values)}
+                isNonInteractive={isNonPendingNonInteractive && isOpenNonInteractive}
               />
             </VisibilityControl>
           </Col>
@@ -81,7 +82,7 @@ const OngoingInfoForm = ({ hiddenFields = {} }) => {
                 <VisibilityControl name="hiddenFields.ongoing.renewalDate">
                   <FieldRenewalDate
                     disabled={!isSubscription}
-                    isNonInteractive={isClosedNonInteractive && !isWorkflowStatusOpen(values)}
+                    isNonInteractive={isClosedNonInteractive && isOpenNonInteractive}
                   />
                 </VisibilityControl>
               </Col>