UIOR-1078: Allow Editing of "Renewal Date" and "Subscription to" on o…

[alisher-epam]

…pen purchase order line

Purpose

UIOR-1078 - Allow Editing of "Renewal Date" and "Subscription to" on open purchase order line

Approach

Screen.Recording.2023-10-05.at.5.05.13.PM.mov

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Statistics

    1 files  ±0  234 suites  ±0   7m 51s ⏱️ - 2m 22s
587 tests +1  587 ✔️ +1  0 💤 ±0  0 ❌ ±0 
595 runs  +1  595 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 5723c68. ± Comparison against base commit 4213d74.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 5723c68. ± Comparison against base commit 4213d74.

♻️ This comment has been updated with latest results.

[usavkov-epam]

Just in case: this story is linked to "Q" release, so please do NOT merge it until the release of ui-orders

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

88.9% Coverage
0.0% Duplication

[usavkov-epam]

I didn’t really understand this PR. The "Purpose" of your PR and the description of the ticket UIOR-1078 tell about changes in the PO line form, but I see in this PR work on the PO form.

[alisher-epam]

I didn’t really understand this PR. The "Purpose" of your PR and the description of the ticket UIOR-1078 tell about changes in the PO line form, but I see in this PR work on the PO form.

Yeah, basically in order to get Open status PR it should have PO lines and we can create it from action menus

[usavkov-epam]

Having merged this PR, are you sure that it fully complies with the requirements of UIOR-1078?

[usavkov-epam]

And don't we need to bump the version to 5.1.0 in the package.json beforehand? @zburke

[zburke]

Yes, package.json needs to be bumped to 5.1.0. I've tried to get in the habit of doing that on the master branch as soon as I make a release, but many folks just do it in the first new-feature PR. Up to you, as long as it happens :)