Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIOR-1365 Close actions dropdown before navigation to another page #1689

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

azizjonnurov
Copy link
Contributor

@azizjonnurov azizjonnurov commented Dec 18, 2024

Purpose

https://folio-org.atlassian.net/browse/UIREC-424

Approach

Toggle Actions menu before redirecting to Receiving app

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Dec 18, 2024

Jest Unit Test Statistics

    1 files  ±0  265 suites  ±0   6m 52s ⏱️ -3s
702 tests +2  702 ✔️ +2  0 💤 ±0  0 ±0 
710 runs  +2  710 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 445533f. ± Comparison against base commit a2475dc.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 18, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 445533f. ± Comparison against base commit a2475dc.

♻️ This comment has been updated with latest results.

@azizjonnurov azizjonnurov requested review from a team December 19, 2024 09:54
src/OrderLinesList/Details/OrderLineDetails.js Outdated Show resolved Hide resolved
src/components/POLine/POLine.js Outdated Show resolved Hide resolved
src/components/POLine/POLineActionMenu/POLineActionMenu.js Outdated Show resolved Hide resolved
src/components/PurchaseOrder/getPOActionMenu.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@azizjonnurov azizjonnurov changed the title UIREC-424 UIOR-1365 Close actions dropdown before navigation to another page Dec 19, 2024
@azizjonnurov azizjonnurov merged commit d130047 into master Dec 23, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIREC-424 branch December 31, 2024 13:54
usavkov-epam pushed a commit that referenced this pull request Dec 31, 2024
…1689)

* Solution attempt

* Wrap onReceive with Promise

* Add change log

* Write tests for POLine and Order receive buttons

* Update change log ticket number

* Add small comment for promise usage

* Improve goToReceive formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants