Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIOR-1325 UIOR-1351 Add submit actions for PO and PO Line forms #1692

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jan 9, 2025

Purpose

https://folio-org.atlassian.net/browse/UIOR-1325
https://folio-org.atlassian.net/browse/UIOR-1351

Enhance the ui-orders module by adding submit functionality for Purchase Order (PO) forms and Purchase Order Line (PO Line) forms. This change aims to improve user workflows and align the module with updated business requirements.

Approach

  • Introduced new actions to handle the submission of PO and PO Line forms.
  • Updated the form validation logic to ensure data consistency during submission.
  • Modified related components to support the new functionality.
  • Added unit tests and integration tests to validate the new features and ensure backward compatibility.

Screenshots

Purchase order form (via "New" button)

chrome_tcdl7HLF0z.mp4

Purchase order form (via Inventory instance)

chrome_Zorzk70ZqM.mp4

Purchase order line form (via "Add")

chrome_Xu3Bvgo7Gt.mp4

Purchase order line form (via Inventory instance)

chrome_khk9qqOMqv.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Jest Unit Test Statistics

    1 files  ±0  265 suites  ±0   7m 8s ⏱️ +15s
708 tests +6  708 ✔️ +6  0 💤 ±0  0 ±0 
716 runs  +6  716 ✔️ +6  0 💤 ±0  0 ±0 

Results for commit d3a561d. ± Comparison against base commit bf8f7c0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 9, 2025

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit d3a561d. ± Comparison against base commit bf8f7c0.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam marked this pull request as ready for review January 10, 2025 15:39
@usavkov-epam usavkov-epam requested a review from a team January 10, 2025 15:44
@usavkov-epam usavkov-epam requested a review from a team January 10, 2025 15:46
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team January 13, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants