-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIORGS-355 Display all versions in change log in fourth pane #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usavkov-epam
force-pushed
the
UIORGS-355
branch
from
November 14, 2024 08:58
95752ff
to
d467f8f
Compare
usavkov-epam
force-pushed
the
UIORGS-355
branch
2 times, most recently
from
November 18, 2024 13:41
9f63ba8
to
795c0b5
Compare
usavkov-epam
force-pushed
the
UIORGS-355
branch
from
November 18, 2024 13:47
795c0b5
to
29b3283
Compare
Quality Gate passedIssues Measures |
@folio-org/fe-tl-reviewers and @folio-org/acquisitions-ui please take a look at the PR |
alisher-epam
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SerhiiNosko
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/UIORGS-355
Enhance the "Change Log" functionality in the
ui-organizations
module by enabling the display of all versions in the fourth pane. This improvement provides users with a more comprehensive view of change history, increasing transparency and usability. It involves updates to the UI components, backend data integration, and the addition of corresponding tests to ensure the feature works as intended.Approach
The implementation approach involves modifying the logic and UI components to support displaying all versions of changes in the fourth pane. This includes updates to API integration for fetching change log data, adjustments to the state management for handling additional data, and changes in rendering logic to dynamically display the full history. Testing is added or updated to ensure the new functionality is robust and aligns with user expectations.
Screenshot
chrome_34dPPotjTS.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.