Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-355 Display all versions in change log in fourth pane #655

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Nov 13, 2024

Purpose

https://folio-org.atlassian.net/browse/UIORGS-355

Enhance the "Change Log" functionality in the ui-organizations module by enabling the display of all versions in the fourth pane. This improvement provides users with a more comprehensive view of change history, increasing transparency and usability. It involves updates to the UI components, backend data integration, and the addition of corresponding tests to ensure the feature works as intended.

Approach

The implementation approach involves modifying the logic and UI components to support displaying all versions of changes in the fourth pane. This includes updates to API integration for fetching change log data, adjustments to the state management for handling additional data, and changes in rendering logic to dynamically display the full history. Testing is added or updated to ensure the new functionality is robust and aligns with user expectations.

Screenshot

chrome_34dPPotjTS.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Jest Unit Test Statistics

    1 files  ±0    86 suites  +2   2m 57s ⏱️ +12s
276 tests +4  274 ✔️ +4  2 💤 ±0  0 ±0 
280 runs  +4  277 ✔️ +4  3 💤 ±0  0 ±0 

Results for commit 91a6801. ± Comparison against base commit 53cecbb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 13, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 91a6801. ± Comparison against base commit 53cecbb.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam force-pushed the UIORGS-355 branch 2 times, most recently from 9f63ba8 to 795c0b5 Compare November 18, 2024 13:41
@usavkov-epam usavkov-epam requested review from a team November 18, 2024 14:18
@usavkov-epam
Copy link
Contributor Author

@folio-org/fe-tl-reviewers and @folio-org/acquisitions-ui please take a look at the PR

Copy link
Contributor

@alisher-epam alisher-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@usavkov-epam usavkov-epam merged commit 9a29cc4 into master Nov 25, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIORGS-355 branch November 25, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants