UIPFU-87 - Fix User Search Modal pagination issue. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manvendra-s-rathore
changed the title
|
Hey @folio-org/fe-tl-reviewers , can someone please review this PR on priority. Its urgent for Q bugfest. |
BogdanDenis
requested changes
Apr 22, 2024
|
Hey @artem-blazhko, we have a tech debt to cover the test cases - UIPFU-78 |
artem-blazhko
approved these changes
Apr 22, 2024
BogdanDenis
approved these changes
Apr 23, 2024
manvendra-s-rathore
added a commit
that referenced
this pull request
May 3, 2024
* UIPFU-87 - fix pagination issue * fix unassign filter pagination * remove console log * fix unassigned filter pagination * resolve review comments --------- Co-authored-by: manvendra-s-rathore <[email protected]>
manvendra-s-rathore
added a commit
that referenced
this pull request
May 3, 2024
* Release v7.1.0 (#255) * UIPFU-87 - Fix User Search Modal pagination issue. (#256) * UIPFU-87 - fix pagination issue * fix unassign filter pagination * remove console log * fix unassigned filter pagination * resolve review comments --------- Co-authored-by: manvendra-s-rathore <[email protected]> * Release v7.1.1 * Update CHANGELOG.md --------- Co-authored-by: Priyanka Terala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIPFU-87 - Fix User Search Modal pagination issue.
The fix includes :-
-> displaying load more button when filtered data > 100.
-> showing correct filtered data count in sub-header (below User Search Results heading).
Screencast
search.user.modal.mp4
Unit tests
Test cases were not covered initially.
We will gradually migrate unit tests in this module to Jest/RTL .
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.