UIPFU-96 - Fix pagination issues on UIPFU in user settings

[Terala-Priyanka]

Purpose

UIPFU-96 - Fix pagination issues on UIPFU in user settings

Approach

Find user plugin will display Status and Patron Group filter groups always and User Assignment Status filter group when invoked from settings > users > Permission sets Assign/unassign button.

Filtering users based on User Assignment Status filter group is not supported by API.
Hence, filtering has been implemented in UI after retrieving records. This lead to pagination issues.

As discussed, and accepted in our standup with our PO, the implementation of pagination in find user plugin, would look like below - (this applies when “User Assignment Status” filter group exists - ex: when plugin invoked from settings > users > ‘Permission sets’)

1. have no pagination when “assigned” filter (with or without combination of filters in other filter groups) is selected.
2. have load more type of pagination when “unassigned” filter (with or without combination of filters in other filter groups) is selected.
3. have prev/next type of pagination in rest of the cases.

Note

The test files for those files in this implementation do not currently exist. We have tech debt tickets in our backlog.
We have started migrating from Big test to Jest. Hence, whatever big test unit tests that might have existed do not reflect too.

Learning

Screencast

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Statistics

10 tests  ±0   10 ✔️ ±0   10s ⏱️ ±0s
  2 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fde7625. ± Comparison against base commit 8598795.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit fde7625. ± Comparison against base commit 8598795.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate failed

Failed conditions
2.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud