UIPFU-85: Migration of unit tests to Jest for ui-plugin-find-user/src/UserSearchView.js #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… /UserSearchView.js
artem-blazhko
approved these changes
Jan 23, 2025
zburke
approved these changes
Jan 24, 2025
src/UserSearchView.js
Outdated
Comment on lines
177
to
178
| data-test-find-user | ||
| data-testid="user-search-view" |
There was a problem hiding this comment.
Given you're adding data-testid can you eliminate the data-test-... attributes?
There was a problem hiding this comment.
Of course. This won’t break things, right?
There was a problem hiding this comment.
I sure hope not! I don't see any related strings in our integration tests (folio-org/stripes-testing) or in the remaining BTOG files here, so it seems safe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for
ui-plugin-find-user/src/UserSearchView.js.https://folio-org.atlassian.net/browse/UIPFU-85