Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPQB-128: Invalid fields handling > Errors when query includes a deleted custom field #193

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

UladzislauKutarkin
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIPQB-128

Here, we added a case of parsing a mongo query with default values in dropdowns because custom fields used for the query can be deleted. By default, if the field is deleted, we will render the default unselected value inside the query builder to prevent the plugin from crashing.

Screen.Recording.2024-12-03.at.15.15.04.mov

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team December 3, 2024 11:57
Copy link

github-actions bot commented Dec 3, 2024

Jest Unit Test Results

  1 files  ±0   12 suites  ±0   1m 12s ⏱️ ±0s
118 tests +1  117 ✅ +1  1 💤 ±0  0 ❌ ±0 
120 runs  +1  119 ✅ +1  1 💤 ±0  0 ❌ ±0 

Results for commit 5aa54c0. ± Comparison against base commit 81686bd.

♻️ This comment has been updated with latest results.

@UladzislauKutarkin UladzislauKutarkin merged commit 4377909 into master Dec 4, 2024
15 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIPQB-128 branch December 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants