UIPQB-55: Regular expressions are incorrect for contains and starts_with operators #63
Conversation
There was a problem hiding this comment.
It would be great to have some of the detail provided in the Jira ticket (which describes the bug) here in the PR title/description which should, instead of describing the problem, describe how the code is changing, e.g. "Avoid extra caret prefix in contains/starts_with queries" instead of "Regular expressions are incorrect...".
A good way to think of PR titles is to complete the sentence, "After this is merged, the code will ..."
| @@ -122,8 +122,8 @@ describe('mongoQueryToSource()', () => { | |||
| { user_last_name: { $lt: 10 } }, | |||
| { user_last_name: { $gte: 'value' } }, | |||
| { languages: { $in: ['value', 'value2'] } }, | |||
| { user_full_name: { $regex: '^abc' } }, | |||
| { user_full_name: { $regex: '^abc' } }, | |||
| { user_full_name: { $regex: 'abc' } }, | |||
There was a problem hiding this comment.
Should this line be duplicated?
There was a problem hiding this comment.
initial and source need to stay in sync. I think you're right that it's a duplicate, @vashjs, but we'd need to purge the related lines throughout the rest of this test file too: lines 62-67, and line 85.
There was a problem hiding this comment.
@zburke thanks for response, you are right. I think we will do small tests clenup in feature stories.
There was a problem hiding this comment.
I removed duplicates. Thanks for your comments.
| @@ -122,8 +122,8 @@ describe('mongoQueryToSource()', () => { | |||
| { user_last_name: { $lt: 10 } }, | |||
| { user_last_name: { $gte: 'value' } }, | |||
| { languages: { $in: ['value', 'value2'] } }, | |||
| { user_full_name: { $regex: '^abc' } }, | |||
| { user_full_name: { $regex: '^abc' } }, | |||
| { user_full_name: { $regex: 'abc' } }, | |||
There was a problem hiding this comment.
@zburke thanks for response, you are right. I think we will do small tests clenup in feature stories.
I completely agree, it’s also a good idea to add screenshots or GIFs where possible, for a better understanding of what has changed. |
|
Kudos, SonarCloud Quality Gate passed! |
UIPQB-55
Purpose
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.