Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPQB-84: Results viewer doesn't show 0 value for number type #92

Merged
merged 1 commit into from
Mar 7, 2024
Merged

UIPQB-84: Results viewer doesn't show 0 value for number type #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* [UIPQB-80](https://issues.folio.org/browse/UIPQB-80) Add operators for NumberType and adjust operators for IntegerType.
* [UIPQB-73](https://folio-org.atlassian.net/browse/UIPQB-73) Result Viewer shows current date if date column is not present.
* [UIPQB-82](https://folio-org.atlassian.net/browse/UIPQB-82) [Query Builder] Support querying based on nested objects within arrays.
* [UIPQB-84](https://folio-org.atlassian.net/browse/UIPQB-84) Results viewer doesn't show 0 value for number type.

## [1.0.0](https://github.com/folio-org/ui-plugin-query-builder/tree/v1.0.0) (2023-10-12)

Expand Down
6 changes: 6 additions & 0 deletions src/QueryBuilder/ResultViewer/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ export const getTableMetadata = (entityType) => {
return item[value] ? <FormattedDate value={item[value]} /> : '';
} else if (dataType === DATA_TYPES.ArrayType) {
return item[value]?.join(' | ');
} else if (dataType === DATA_TYPES.NumberType) {
if (item[value] === undefined) {
return '';
}

return item[value];
} else {
// If value is empty we will return empty string
// instead of undefined
Expand Down
Loading