Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPQB-74: Non-default fields that are part of the query are automatically displayed as columns #93

Merged
merged 4 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* [UIPQB-82](https://folio-org.atlassian.net/browse/UIPQB-82) [Query Builder] Support querying based on nested objects within arrays.
* [UIPQB-84](https://folio-org.atlassian.net/browse/UIPQB-84) Results viewer doesn't show 0 value for number type.
* [UIPQB-78](https://folio-org.atlassian.net/browse/UIPQB-78) Query builder display if no records match the query
* [UIPQB-74](https://folio-org.atlassian.net/browse/UIPQB-74)Non-default fields that are part of the query are automatically displayed as columns

## [1.0.0](https://github.com/folio-org/ui-plugin-query-builder/tree/v1.0.0) (2023-10-12)

Expand Down
10 changes: 6 additions & 4 deletions src/QueryBuilder/QueryBuilder/TestQuery/TestQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@ export const TestQuery = ({
isTestQueryInProgress,
setIsTestQueryInProgress,
recordsLimit,
forcedVisibleValues,
}) => {
const queryClient = useQueryClient();

const [columns, setColumns] = useState([]);
const [visibleColumns, setVisibleColumns] = useState(recordColumns);

const [includeContent, setIncludeContent] = useState(true);
const [recordsLimitExceeded, setRecordsLimitExceeded] = useState(false);

Expand Down Expand Up @@ -115,10 +117,8 @@ export const TestQuery = ({
};

const handleDefaultVisibleColumnsChange = (values) => {
if (!visibleColumns.length) {
setVisibleColumns(values);
onSetDefaultVisibleColumns(values);
}
setVisibleColumns(values);
onSetDefaultVisibleColumns(values);
};

const renderDropdown = ({ currentRecordsCount }) => !!currentRecordsCount && (
Expand Down Expand Up @@ -166,6 +166,7 @@ export const TestQuery = ({
<ResultViewer
onSuccess={handleQueryRetrieved}
onPreviewShown={handlePreviewShown}
forcedVisibleValues={forcedVisibleValues}
onSetDefaultColumns={setColumns}
onSetDefaultVisibleColumns={handleDefaultVisibleColumnsChange}
contentDataSource={queryDetailsDataSource}
Expand Down Expand Up @@ -208,4 +209,5 @@ TestQuery.propTypes = {
setIsTestQueryInProgress: PropTypes.func,
recordsLimit: PropTypes.number,
recordColumns: PropTypes.arrayOf(PropTypes.string),
forcedVisibleValues: PropTypes.arrayOf(PropTypes.string),
};
6 changes: 4 additions & 2 deletions src/QueryBuilder/ResultViewer/ResultViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const ResultViewer = ({
isPreviewLoading,
additionalControls,
refreshInProgress,
forcedVisibleValues,
}) => {
const intl = useIntl();

Expand All @@ -45,7 +46,6 @@ export const ResultViewer = ({
isContentDataLoading,
isContentDataFetching,
isEntityTypeLoading,
isContentTypeFetchedAfterMount,
columnMapping,
defaultColumns,
defaultVisibleColumns,
Expand All @@ -61,21 +61,22 @@ export const ResultViewer = ({
queryParams,
contentQueryOptions,
contentQueryKeys,
forcedVisibleValues,
});

const isListLoading = isContentDataFetching || isContentDataLoading || isEntityTypeLoading || refreshInProgress;
const currentRecordsCount = contentData?.length || 0;

// set visible by default columns once
useViewerCallbacks({
isContentTypeFetchedAfterMount,
onSetDefaultColumns,
defaultColumns,
onSetDefaultVisibleColumns,
defaultVisibleColumns,
currentRecordsCount,
onPreviewShown,
defaultLimit,
forcedVisibleValues,
});

// refresh functionality
Expand Down Expand Up @@ -206,4 +207,5 @@ ResultViewer.propTypes = {
contentQueryKeys: PropTypes.arrayOf(PropTypes.string),
additionalControls: PropTypes.element,
refreshInProgress: PropTypes.bool,
forcedVisibleValues: PropTypes.arrayOf(PropTypes.string),
};
1 change: 1 addition & 0 deletions src/QueryBuilder/ResultViewer/ResultViewer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const renderResultViewer = (props) => (
onSetDefaultColumns={setColumns}
height={300}
refreshInProgress={false}
forcedVisibleValues={['username']}
{...props}
/>
</QueryClientProvider>
Expand Down
6 changes: 4 additions & 2 deletions src/QueryBuilder/ResultViewer/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { FormattedDate } from 'react-intl';
import { DATA_TYPES } from '../../constants/dataTypes';
import { DynamicTable } from './DynamicTable/DynamicTable';

export const getTableMetadata = (entityType) => {
export const getTableMetadata = (entityType, forcedVisibleValues) => {
const defaultColumns = entityType?.columns?.map((cell) => ({
label: cell.labelAlias,
value: cell.name,
Expand All @@ -19,7 +19,9 @@ export const getTableMetadata = (entityType) => {
return acc;
}, {});

const defaultVisibleColumns = defaultColumns?.filter(col => col.selected).map(col => col.value) || [];
const defaultVisibleColumns = defaultColumns?.filter(col => !!forcedVisibleValues?.find(value => value === col.value)
|| col.selected).map(col => col.value) || [];

const formatter = defaultColumns.reduce((formatted, column) => {
const { value, dataType, properties } = column;

Expand Down
8 changes: 7 additions & 1 deletion src/hooks/useAsyncDataSource.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const useAsyncDataSource = ({
onSuccess,
contentQueryOptions,
contentQueryKeys,
forcedVisibleValues,
}) => {
const [debouncedOffset, debouncedLimit] = useDebounce([offset, limit], 200);

Expand Down Expand Up @@ -44,7 +45,12 @@ export const useAsyncDataSource = ({

const { content: contentData, totalRecords, status } = recordsData || {};

const { columnMapping, defaultColumns, defaultVisibleColumns, formatter } = getTableMetadata(entityType);
const {
columnMapping,
defaultColumns,
defaultVisibleColumns,
formatter,
} = getTableMetadata(entityType, forcedVisibleValues);

return {
contentData,
Expand Down
5 changes: 2 additions & 3 deletions src/hooks/useViewerCallbacks.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { useEffect } from 'react';

export const useViewerCallbacks = ({
isContentTypeFetchedAfterMount,
onSetDefaultColumns,
defaultColumns,
onSetDefaultVisibleColumns,
Expand All @@ -11,11 +10,11 @@ export const useViewerCallbacks = ({
defaultLimit,
}) => {
useEffect(() => {
if (isContentTypeFetchedAfterMount) {
if (defaultColumns.length !== 0) {
onSetDefaultColumns?.(defaultColumns);
onSetDefaultVisibleColumns?.(defaultVisibleColumns);
}
}, [isContentTypeFetchedAfterMount]);
}, [currentRecordsCount]);

useEffect(() => {
if (currentRecordsCount) onPreviewShown?.({ currentRecordsCount, defaultLimit });
Expand Down
Loading