UIQM-588 Use Authority search to get Authority linked records count. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandberger
reviewed
Nov 29, 2023
| import { useTenantKy } from '../../temp'; | ||
|
|
||
| const useAuthorityLinksCount = ({ tenantId } = {}) => { | ||
| const useAuthorityLinksCount = ({ id, tenantId } = {}) => { |
There was a problem hiding this comment.
There is no need to change the tenant for this search/authorities API. We can remove tenantId.
| import { useTenantKy } from '../../temp'; | ||
|
|
||
| const useAuthorityLinksCount = ({ tenantId } = {}) => { | ||
| const useAuthorityLinksCount = ({ id, tenantId } = {}) => { | ||
| const ky = useTenantKy({ tenantId }); |
There was a problem hiding this comment.
useOkapiKy already supports the tenant.
There was a problem hiding this comment.
This ticket has been added to the poppy bug fix release, useOkapiKy doesn't support the tenant there, no need to change.
zburke
approved these changes
Dec 6, 2023
OleksandrHladchenko1
approved these changes
Dec 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
BogdanDenis
added a commit
that referenced
this pull request
Dec 11, 2023
…625) * UIQM-588 Use Authority search to get Authority linked records count. * UIQM-588 Updated tests * UIQM-588 Added search interface * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Authority search to get Authority linked records count.
Screenshots
chrome_HHj1YnFDFN.mp4
Issues
UIQM-588