UIREC-308 Add validation for the claimingInterval field
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +73,35 @@ describe('TitleForm', () => { | |||
| expect(claimingIntervalField).toHaveValue(null); | |||
| }); | |||
|
|
|||
| it('should validate \'Claiming interval\' field', async () => { | |||
There was a problem hiding this comment.
I suggest separating all these checks into separate test cases. You have a lot of checks here, if one of them fails, you won't be able to detect which one exactly does. Try the next structure:
describe('when "Claiming active" unchecked', () => {
it('field shouldn't be required')
});
describe('when "Claiming active" checked', () => {
it('field should be required')
});
and so onThere was a problem hiding this comment.
Thanks for the suggestion! However, this test is also designed to track the state of the field over time, so it is reduced to one test, this allows us to ensure that validation works when dependent fields change.
Terala-Priyanka
approved these changes
Jan 1, 2024
SerhiiNosko
approved these changes
Jan 3, 2024
usavkov-epam
force-pushed
the
UIREC-308
branch
from
993399d to
f56f81d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIREC-308
Claiming interval should be a required field when claiming is active for a receiving title.
Approach
Apply validation for claiming interval field when it's required field (claiming active).
Screenshot
chrome_jEfnyWInPk.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.