Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREC-292 Provide independent 'disabled' status for piece actions #478

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jan 5, 2024

Purpose

https://issues.folio.org/browse/UIREC-292?focusedCommentId=200172&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-200172

Save actions are expected to be disabled until a user makes any changes to the existing piece.

Approach

Make it possible to specify separate actions as disabled.

Screenshot

chrome_OHrJ69Vcs2.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Jan 5, 2024

Jest Unit Test Statistics

212 tests  ±0   211 ✔️ ±0   3m 28s ⏱️ +3s
  67 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 5d3450b. ± Comparison against base commit 04948fb.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
getPieceActionMenus delete action should `delete` button be disabled if `canDeletePiece` is false ‑ getPieceActionMenus delete action should `delete` button be disabled if `canDeletePiece` is false
getPieceActionMenus delete action should `delete` button be disabled ‑ getPieceActionMenus delete action should `delete` button be disabled

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 5, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 5d3450b. ± Comparison against base commit 04948fb.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested review from a team and alisher-epam January 5, 2024 13:59
@usavkov-epam usavkov-epam requested a review from a team January 11, 2024 06:06
Copy link

@usavkov-epam usavkov-epam changed the base branch from master to develop January 11, 2024 08:07
@usavkov-epam usavkov-epam merged commit e7aeb65 into develop Jan 11, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIREC-292 branch January 11, 2024 11:33
NikitaSedyx pushed a commit that referenced this pull request Feb 1, 2024
* UIREC-292 Provide independent 'disabled' status for piece actions

* UIREC-292 Handle create another piece state

* provide default value

* update comment

* fix test

* Mock resize observer
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
* UIREC-292 Provide independent 'disabled' status for piece actions

* UIREC-292 Handle create another piece state

* provide default value

* update comment

* fix test

* Mock resize observer
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
* UIREC-292 Provide independent 'disabled' status for piece actions

* UIREC-292 Handle create another piece state

* provide default value

* update comment

* fix test

* Mock resize observer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants