UIREC-292: fix update item status on unreceive piece #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSedyx
reviewed
Jan 25, 2024
Dmytro-Melnyshyn
approved these changes
Jan 26, 2024
|
|
||
| return unreceive([currentPiece]) | ||
| .then(() => { | ||
| onStatusChange(PIECE_STATUS.expected); |
There was a problem hiding this comment.
If I'm not mistaken, calling "unreceive" API updates the piece status and you don't need to do it again.
There was a problem hiding this comment.
Let me check it.
There was a problem hiding this comment.
Screen.Recording.2024-01-29.at.13.31.27.mov
|
usavkov-epam
approved these changes
Jan 30, 2024
NikitaSedyx
pushed a commit
that referenced
this pull request
Feb 1, 2024
* UIREC-292: fix update item status on unreceive piece * fix failing test * test: improve test coverage * refactor by adding custom `useUnreceive` hook * tests: fix failing tests * refactor useUnreceive hook * update onUnreceivePiece callback function * fix failing test case * refactor onunrecieve callback * tests: add test coverage * update package.json interface versions * revert package.json interface version due to wrong PR
NikitaSedyx
pushed a commit
that referenced
this pull request
Feb 21, 2024
* UIREC-292: fix update item status on unreceive piece * fix failing test * test: improve test coverage * refactor by adding custom `useUnreceive` hook * tests: fix failing tests * refactor useUnreceive hook * update onUnreceivePiece callback function * fix failing test case * refactor onunrecieve callback * tests: add test coverage * update package.json interface versions * revert package.json interface version due to wrong PR
NikitaSedyx
pushed a commit
that referenced
this pull request
Feb 21, 2024
* UIREC-292: fix update item status on unreceive piece * fix failing test * test: improve test coverage * refactor by adding custom `useUnreceive` hook * tests: fix failing tests * refactor useUnreceive hook * update onUnreceivePiece callback function * fix failing test case * refactor onunrecieve callback * tests: add test coverage * update package.json interface versions * revert package.json interface version due to wrong PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIREC-292 - fix update item status on unreceive piece according to the comment here Video source
Approach
Screen.Recording.2024-01-24.at.19.33.10.mov
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.