-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIREC-307 Expect "Unreceivable" pieces on the full screen form #485
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This code is clear, intuitive, and easy to follow. Nice work! The way you anticipated this feature in the previous Promise.reject
implementation was a nice touch. Kudos!
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form * UIREC-307 unit tests
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form * UIREC-307 unit tests
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form * UIREC-307 unit tests
Purpose
https://issues.folio.org/browse/UIREC-307
Approach
Use "expect" API to update pieces statuses.
Screenshot
chrome_DyUJEXrK4U.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.