Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREC-307 Expect "Unreceivable" pieces on the full screen form #485

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jan 26, 2024

Purpose

https://issues.folio.org/browse/UIREC-307

Approach

Use "expect" API to update pieces statuses.

Screenshot

chrome_DyUJEXrK4U.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Jan 26, 2024
@usavkov-epam usavkov-epam changed the base branch from master to develop January 26, 2024 10:45
Copy link

github-actions bot commented Jan 26, 2024

Jest Unit Test Statistics

214 tests  +2   213 ✔️ +2   3m 40s ⏱️ +8s
  68 suites +1       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 276a64c. ± Comparison against base commit 450b7ac.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 26, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 276a64c. ± Comparison against base commit 450b7ac.

♻️ This comment has been updated with latest results.

Copy link

@usavkov-epam usavkov-epam requested review from a team January 26, 2024 11:17
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This code is clear, intuitive, and easy to follow. Nice work! The way you anticipated this feature in the previous Promise.reject implementation was a nice touch. Kudos!

@usavkov-epam usavkov-epam merged commit 1a5cd3e into develop Jan 29, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIREC-307 branch January 29, 2024 10:34
NikitaSedyx pushed a commit that referenced this pull request Feb 1, 2024
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form

* UIREC-307 unit tests
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form

* UIREC-307 unit tests
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
* UIREC-307 Expect 'Unreceivable' pieces on the full screen form

* UIREC-307 unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants