Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREC-275: support error codes for pieces receive and unreceive actions #489

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

alisher-epam
Copy link
Contributor

@alisher-epam alisher-epam commented Jan 31, 2024

Purpose

UIREC-275 - UIREC-275: support error codes for pieces receive and unreceive actions

Approach

Screen.Recording.2024-01-31.at.19.12.32.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam requested review from a team January 31, 2024 14:17
Copy link

Jest Unit Test Statistics

219 tests  +2   218 ✔️ +2   3m 31s ⏱️ -2s
  69 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 3e29e6b. ± Comparison against base commit 54cf43c.

Copy link

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 3e29e6b. ± Comparison against base commit 54cf43c.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alisher-epam alisher-epam merged commit 59dd6fb into develop Feb 1, 2024
6 checks passed
@alisher-epam alisher-epam deleted the UIREC-275 branch February 1, 2024 06:02
NikitaSedyx pushed a commit that referenced this pull request Feb 1, 2024
…ns (#489)

* UIREC-275: support error codes for pieces receive and unreceive actions

* update changelog file
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
…ns (#489)

* UIREC-275: support error codes for pieces receive and unreceive actions

* update changelog file
NikitaSedyx pushed a commit that referenced this pull request Feb 21, 2024
…ns (#489)

* UIREC-275: support error codes for pieces receive and unreceive actions

* update changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants