UI req 990 add dropdown for item service point #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgupta-nla
requested review from
nlaforwardism,
fcrimmins and
artem-blazhko
fcrimmins
reviewed
Oct 2, 2023
| @@ -221,6 +221,7 @@ export const requestFilterTypes = { | |||
| REQUEST_STATUS: 'requestStatus', | |||
| REQUEST_LEVELS: 'requestLevels', | |||
| PICKUP_SERVICE_POINT: 'pickupServicePoints', | |||
| EffLocation_SERVICE_POINT: 'effectiveLocationPrimaryServicePoint', | |||
There was a problem hiding this comment.
Should this be an all-caps constant name to match the other types?
fcrimmins
approved these changes
Oct 2, 2023
Dmitriy-Litvinenko
requested changes
Oct 5, 2023
| displayClearButton={!isEmpty(activeValues)} | ||
| id={name} | ||
| header={FilterAccordionHeader} | ||
| label="Effective Location Primary Service Point Name" |
There was a problem hiding this comment.
Could you please move label text to translation?
Could you please clarify label (current text not consistency)?
| } from '@folio/jest-config-stripes/testing-library/react'; | ||
| import userEvent from '@folio/jest-config-stripes/testing-library/user-event'; | ||
|
|
||
| import '__mock__'; |
There was a problem hiding this comment.
Could you please remove?
| @@ -161,6 +161,7 @@ | |||
| "item.status.orderClosed": "Order closed", | |||
| "item.status.restricted": "Restricted", | |||
| "title.information": "Title information", | |||
| "requests.itemEffectiveLocationPrimaryServicePointName": "Effective Location Primary Service Point Name", | |||
There was a problem hiding this comment.
Could you please clarify text (current text not consistency)?
|
Could you please resolve conflict and fix feedback? |
|
We close current pull request. Pull request long time without any updates, need rebase and etc. If needed can be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIREQ-989
To populate the drop down the (ServicePoint) code will need to be used, this allows the already existing service point code to be leveraged.
User must have the view request permission. Users: View requests, this should also limit them to their assigned service point/s. (This may need to be updated to suit general open source) This does match the generic permission in snapshot.
Approach
The request list is filtered in the backend based on the item selected in Primary Service Point name dropdown in the ui.
Refs
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.