Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIREQ-1039: Request Action - Create new option Print search slips #1122

Merged
merged 3 commits into from
Nov 16, 2023
Merged

UIREQ-1039: Request Action - Create new option Print search slips #1122

merged 3 commits into from
Nov 16, 2023

Conversation

Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Nov 14, 2023 •
edited
Loading

Purpose

Request Action - Create new option Print search slips

Refs

https://issues.folio.org/browse/UIREQ-1039

Screenshots

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    50 suites  ±0   1m 37s ⏱️ +2s
611 tests +5  611 ✔️ +5  0 💤 ±0  0 ❌ ±0 
612 runs  +5  612 ✔️ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 332b330. ± Comparison against base commit 69bdc4b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 332b330. ± Comparison against base commit 69bdc4b.

♻️ This comment has been updated with latest results.

artem-blazhko
artem-blazhko approved these changes Nov 14, 2023
View reviewed changes
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
@artem-blazhko artem-blazhko requested a review from a team November 14, 2023 14:13
mariia-aloshyna
mariia-aloshyna reviewed Nov 14, 2023
View reviewed changes
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
BogdanDenis
BogdanDenis requested changes Nov 14, 2023
View reviewed changes
src/routes/RequestsRoute.js Outdated Show resolved Hide resolved
src/components/PrintContent/PrintContent.js Outdated Show resolved Hide resolved
@Dmitriy-Litvinenko
Copy link
Contributor Author

@mariia-aloshyna @BogdanDenis @artem-blazhko Thank you for review, all feedback fixed. Also was renamed Pick Slips variables for consistency with Search Slips in according with feedback. All fix in 5eb64de Could you please re-review?

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit 9c825d8 into master Nov 16, 2023
5 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UIREQ-1039 branch November 16, 2023 18:14
@Dmitriy-Litvinenko Dmitriy-Litvinenko mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-blazhko artem-blazhko artem-blazhko approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@mariia-aloshyna mariia-aloshyna Awaiting requested review from mariia-aloshyna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dmitriy-Litvinenko @BogdanDenis @artem-blazhko @mariia-aloshyna