Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1188 - Add optional column "Retrieval service point" to requests search list. (follow-up) #1242

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Dec 5, 2024

Purpose

UIREQ-1188 - Add optional column "Retrieval service point" to requests search list.

Approach

Refs

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Dec 5, 2024

Jest Unit Test Statistics

       1 files  ±0       62 suites  ±0   1m 49s ⏱️ ±0s
   800 tests ±0     800 ✔️ ±0  0 💤 ±0  0 ±0 
1 110 runs  +1  1 110 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 48de066. ± Comparison against base commit ab3ef5e.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here is to the CHANGELOG. Did something else get lost in the merge?

@Terala-Priyanka
Copy link
Contributor Author

The only change here is to the CHANGELOG. Did something else get lost in the merge?

Hey @zburke
There is no file missed or lost in previous merge. I did have to duplicate the changes of my earlier PR in another folder named "deprecated". This ensures that changes are reflected in all environments, irrespective of the flag set in stripes config

I have updated PR with the same. Could you please re-review now?

@Terala-Priyanka Terala-Priyanka requested review from zburke and a team December 9, 2024 06:51
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team December 9, 2024 10:44
@Terala-Priyanka Terala-Priyanka merged commit d6ccac0 into master Dec 9, 2024
5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIREQ-1188 branch December 9, 2024 16:14
@Dmitriy-Litvinenko Dmitriy-Litvinenko restored the UIREQ-1188 branch January 9, 2025 20:00
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UIREQ-1188 branch January 9, 2025 20:03
Dmitriy-Litvinenko pushed a commit that referenced this pull request Jan 10, 2025
…s search list. (follow-up) (#1242)

* UIREQ-1188 - Add optional column 'Retrieval service point'

* Male retieval sp column sortable

* add unit test

* UIREQ-1188 - update changelog.md file.

* UIREQ-1188 - duplicate the implementation in deprecated folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants