Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1044: Increase code coverage for src/ChooseRequestTypeDialog.js by Jest/RTL tests #1243

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

artem-blazhko
Copy link
Contributor

Purpose

Increase code coverage for src/ChooseRequestTypeDialog.js by Jest/RTL tests

Refs

UIREQ-1044

Copy link

github-actions bot commented Dec 6, 2024

Jest Unit Test Statistics

       1 files  ±0       62 suites  ±0   1m 44s ⏱️ +6s
   800 tests +2     800 ✔️ +2  0 💤 ±0  0 ±0 
1 109 runs  +2  1 109 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 2bf3b3c. ± Comparison against base commit 7edd21a.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Dec 6, 2024

@artem-blazhko artem-blazhko requested a review from a team December 6, 2024 10:25
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You don't have to change anything now, but generally, prefer user-event to fireEvent as indicated in the docs: "Most projects have a few use cases for fireEvent, but the majority of the time you should probably use @testing-library/user-event."

@artem-blazhko artem-blazhko merged commit ab3ef5e into master Dec 6, 2024
5 checks passed
@artem-blazhko artem-blazhko deleted the UIREQ-1044 branch December 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants