UIU-3025 - Create new permission 'Users: Can view, edit, and delete profile pictures' #2619
Conversation
There was a problem hiding this comment.
Please follow the naming conventions: "The naming scheme is a faceted dot-separated string, with the delimited terms as hyphen-separated words."
It would be great to fix the other profilepictures permission that was created incorrectly in PR #2609 before it becomes further entrenched. Please, sing about these conventions far and wide. Tell your friends. Tell your enemies. Tell everybody! Some of our APIs are complicated for good reasons and that's fine, but the self-inflicted wound of failing to follow our own conventions hurts double.
package.json
Outdated
| "displayName": "Users: Can view, edit, and delete profile pictures", | ||
| "description": "Also includes basic permissions to edit user profile", | ||
| "subPermissions": [ | ||
| "ui-users.profilepictures.view", |
There was a problem hiding this comment.
Use profile-picture in place of profilepicture. Petty, sorry; developers are so cranky about names 😅 Be consistent with the name already established in the back-end permissions. Alas, consistency on single vs plural is a battle I lost years ago. Curse DHH and his awful Rails ORM naming conventions, the worst decision he ever made.
|
Purpose
UIU-3025 - Add "Users: Can view, edit, and delete profile pictures" permission
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.