UIU-3005 - Display Profile picture on edit screen based on user permission. #2620
Conversation
Terala-Priyanka
changed the title
This reverts commit 322a455.
Terala-Priyanka
requested review from
a team and
manvendra-s-rathore
and removed request for
a team
| <Dropdown | ||
| data-testId="updateProfilePictureDropdown" | ||
| id="updateProfilePictureDropdown" | ||
| label="Update" |
There was a problem hiding this comment.
Thank you for identifying it @zburke
I have added the needful. Please re-review.
There was a problem hiding this comment.
Please correct a few more missing i18n strings. I don't have context for the rest of this work so I am hesitant to review, but I'll be happy to dismiss my "request changes" comment once the i18n changes are in place so you can merge with approval from your team.
| aria-label="profile picture action menu" | ||
| role="menu" | ||
| > | ||
| <Button buttonStyle="dropdownItem"><Icon icon="profile">Local File</Icon></Button> | ||
| <Button buttonStyle="dropdownItem"><Icon icon="external-link">External URL</Icon></Button> | ||
| <Button buttonStyle="dropdownItem"><Icon icon="trash">Delete</Icon></Button> |
| <Label tagName="div"> | ||
| {label} | ||
| </Label> | ||
| { renderProfilePic()} |
There was a problem hiding this comment.
Should this be <Label>{renderProfilePic()}</Label> instead? It's a bit odd to see a <Label> all on its own, unattached to a field since its raison d'être is to label a field.
|
Purpose
UIU-3005 - Integrate UX wireframes based on permission - "Users: Can view, edit, and delete profile pictures"
Approach
Screencast
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.