Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3021: add edit user roles accordion to user edit view #2671

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

aidynoJ
Copy link
Contributor

@aidynoJ aidynoJ commented Apr 18, 2024

Purpose

Approach

Add user roles accordion into edit user

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@aidynoJ aidynoJ marked this pull request as draft April 18, 2024 13:11
@aidynoJ aidynoJ marked this pull request as ready for review April 19, 2024 12:47
@aidynoJ aidynoJ requested review from zburke and ryandberger April 22, 2024 12:22
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we get that test filename fixed.

Copy link

@aidynoJ aidynoJ merged commit 5377979 into keycloak-ramsons Apr 25, 2024
5 checks passed
ryandberger pushed a commit that referenced this pull request Apr 29, 2024
zburke pushed a commit that referenced this pull request Jun 10, 2024
ryandberger pushed a commit that referenced this pull request Jul 26, 2024
ryandberger pushed a commit that referenced this pull request Jul 26, 2024
@zburke zburke deleted the UIU-3021 branch October 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants