Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3094: "Total paid amount" value is set as "$NaN" on "Refund fee/fine" modal #2672

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

artem-blazhko
Copy link
Contributor

Purpose

Fix issue with "Total paid amount" value that has incorrect view.

Approach

Property that is used for "Total paid amount" value is totalPaidAmount. At the parent component this property was handled by localizeCurrencyAmount method and then inside ActionModal component it was handled by that method one more time. As a result we had $NaN. To fix this problem I had to remove one unnecessary handling.

Refs

UIU-3094

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@artem-blazhko artem-blazhko requested a review from a team April 22, 2024 09:23
@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team April 23, 2024 08:03
@artem-blazhko artem-blazhko merged commit af37d83 into master Apr 23, 2024
5 checks passed
@artem-blazhko artem-blazhko deleted the UIU-3094 branch April 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants