Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build on ubuntu-20.04 to ensure compatibility #19

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Dec 18, 2024

No description provided.

@ronaldtse
Copy link
Contributor

I believe this will fix:

@maxirmx maxirmx force-pushed the maxirmx-fix-ubuntu branch 3 times, most recently from 0afaa8f to 86b73d0 Compare December 21, 2024 10:31
@maxirmx
Copy link
Contributor Author

maxirmx commented Dec 21, 2024

@CAMOBAP @ronaldtse
Seesking help .... Why rake for metanorma fails like in this run https://github.com/fontist/ffi-libarchive-binary/actions/runs/12444447089/job/34744929504 ? Is it something related to libarchive ?

Thank you

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Dec 21, 2024

@maxirmx to b on the same page in https://github.com/fontist/ffi-libarchive-binary/actions/runs/12444447089/job/34744929504 where exactly it fails? All jobs look green

@maxirmx
Copy link
Contributor Author

maxirmx commented Dec 21, 2024

@maxirmx to b on the same page in https://github.com/fontist/ffi-libarchive-binary/actions/runs/12444447089/job/34744929504 where exactly it fails? All jobs look green

In "metanorma" jobs it fails on "bundle exec rake"
I set contineue-on-failure: true to be able test container
Sorry for confusion

@maxirmx
Copy link
Contributor Author

maxirmx commented Dec 21, 2024

The same issue with other gems
https://github.com/fontist/fontist/actions/runs/12446693626/job/34749370945?pr=390
so I assume it is not related to my changes

@maxirmx maxirmx marked this pull request as ready for review December 21, 2024 17:32
@maxirmx maxirmx merged commit 901f23c into main Dec 21, 2024
31 checks passed
@maxirmx maxirmx deleted the maxirmx-fix-ubuntu branch December 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants