Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https for metadata url #4978

Closed
wants to merge 1 commit into from
Closed

use https for metadata url #4978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/fontbakery/checks/vendorspecific/googlefonts/conditions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ def production_metadata(context):

import requests

meta_url = "http://fonts.google.com/metadata/fonts"
meta_url = "https://fonts.google.com/metadata/fonts"
return requests.get(meta_url, timeout=context.config.get("timeout")).json()


Expand Down
6 changes: 3 additions & 3 deletions tests/test_checks_googlefonts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@ def test_check_metadata_includes_production_subsets(check, requests_mock):
"""Check METADATA.pb has production subsets."""

requests_mock.get(
"http://fonts.google.com/metadata/fonts",
"https://fonts.google.com/metadata/fonts",
json={
"familyMetadataList": [
{
Expand Down Expand Up @@ -2686,7 +2686,7 @@ def test_check_repo_zip_files(check, tmp_path):
@check_id("googlefonts/vertical_metrics")
def test_check_vertical_metrics(check, requests_mock):
requests_mock.get(
"http://fonts.google.com/metadata/fonts",
"https://fonts.google.com/metadata/fonts",
json={
"familyMetadataList": [
{"family": "Akshar"},
Expand Down Expand Up @@ -2959,7 +2959,7 @@ def new_context():
@check_id("googlefonts/cjk_vertical_metrics")
def test_check_cjk_vertical_metrics(check, requests_mock):
requests_mock.get(
"http://fonts.google.com/metadata/fonts",
"https://fonts.google.com/metadata/fonts",
json={
"familyMetadataList": [],
},
Expand Down
Loading