@W-14689505@: Action Implementation (Part 1 of 2) - all except results analysis #2
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
stephen-carter-at-sf
changed the title
stephen-carter-at-sf
force-pushed
the
d/W-14689505
branch
3 times, most recently
from
81c43c6 to
5a04a2d
Compare
stephen-carter-at-sf
force-pushed
the
d/W-14689505
branch
from
5a04a2d to
2d7cb3a
Compare
| "moduleResolution": "NodeNext", | ||
| "baseUrl": "./", | ||
| "sourceMap": true, | ||
| "outDir": "./dist_local", |
There was a problem hiding this comment.
Note that the npm run package command uses ncc to compile the index.ts and all its dependencies into a single index.js file inside of the dist folder. In fact there is a github action to confirm that we don't accidentally submit anything else from dist. To make things neat and organized for local development, i have chosen to have the compile to compile to dist_local instead which is on the .gitignore list now. Also note that this ncc really helps us not have to worry about accidentally shipping the tests - so I was able to make the root directory "." and include the tests in the main build and linting.
| // TODO: NICE TO HAVES: | ||
| // * Verify that Salesforce CLI "sf" is installed | ||
| // * Verify that sfdx-scanner plugin is installed (and if not, then install it as a separate step) | ||
| // * Echo version of sfdx-scanner in use |
There was a problem hiding this comment.
I hope to do these along with the output analysis in the next work item. And I might break it up into 2 separate PRs to make things easy.
| }) | ||
|
|
||
| it('Test trailing -o', async () => { | ||
| const outfile1 = extractOutfileFromRunArguments('--normalize-severity -o ') |
There was a problem hiding this comment.
When this command actually tries to run, they'll get an error because the flag expects a value.
There was a problem hiding this comment.
I understand. This is just an extra added level of protection.
No description provided.