update to LSP 0.0.12 (#89)

* update to LSP 0.0.12 * address feedback
forcedotcom · Jul 13, 2021 · 2a5b8f1 · 2a5b8f1
1 parent e6e7b8b
commit 2a5b8f1
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
-
+## [1.4.7]
+Updates/enhancements:
+- Enable suppression of SLDS warnings in HTML files for mobile via Quick Fix actions. Any HTML content that is between `<!-- sldsValidatorIgnore -->` and `<!-- sldsValidatorAllow -->` will now be exempt from SLDS validation. Furthermore `<!-- sldsValidatorIgnoreNextLine -->` will exempt the next immediate line from SLDS validation. By adding a `<!-- sldsValidatorIgnore -->` at the top of an HTML file with no `<!-- sldsValidatorAllow -->` anywhere else in that file, you can exempt the entire content of the file from SLDS validation.
+- New preference flag for SLDS Validator extension. Now using `Salesforce-vscode-slds > Basic : Mobile Validation` flag you can globally enable or disable SLDS validation for mobile.
+- Update LSP: https://github.com/forcedotcom/salesforcedx-slds-lsp/releases/tag/v0.0.12
 ## [1.4.6]
 - Update LSP: https://github.com/forcedotcom/salesforcedx-slds-lsp/releases/tag/v0.0.11
 

diff --git a/client/src/commands/index.ts b/client/src/commands/index.ts
@@ -62,5 +62,9 @@ export class Commands {
 			this.context.updateState(ContextKey.SCOPE, true));
 		vscode.commands.registerCommand('slds.disable:scope', ()=>
 			this.context.updateState(ContextKey.SCOPE, false));
+		vscode.commands.registerCommand('slds.enable:mobileValidation', ()=>
+			this.context.updateState(ContextKey.SLDS_MOBILE_VALIDATION, true));
+		vscode.commands.registerCommand('slds.disable:mobileValidation', ()=>
+			this.context.updateState(ContextKey.SLDS_MOBILE_VALIDATION, false));
 	}
 }
diff --git a/client/src/context/context.ts b/client/src/context/context.ts
@@ -22,7 +22,8 @@ const MAPPINGS: Map<ContextKey, string> = new Map<ContextKey, string>([
 	[ContextKey.DESIGN_TOKEN, 'basic.designToken'],
 	[ContextKey.INVALID, 'basic.invalid'],
 	[ContextKey.UTILITY_CLASS, 'enhancements.utilityClasses'],
-	[ContextKey.SCOPE, 'file.scopeWithInSFDX']
+	[ContextKey.SCOPE, 'file.scopeWithInSFDX'],
+	[ContextKey.SLDS_MOBILE_VALIDATION, 'basic.mobileValidation']
 ]);
 
 export class SLDSContext {

diff --git a/client/src/context/contextKey.ts b/client/src/context/contextKey.ts
@@ -21,5 +21,6 @@ export enum ContextKey {
 	UTILITY_CLASS = "UTILITY_CLASS",
 	DESIGN_TOKEN = "DESIGN_TOKEN",
 	AUTO_SUGGEST = "AUTO_SUGGEST",
-	SCOPE = "SCOPE"
+	SCOPE = "SCOPE",
+	SLDS_MOBILE_VALIDATION = "SLDS_MOBILE_VALIDATION"
 }
diff --git a/client/src/sldsLanguageClient.ts b/client/src/sldsLanguageClient.ts
@@ -165,7 +165,7 @@ function createServerPromise(context: ExtensionContext, outputChannel: OutputCha
 			}
 
 			args.push('-jar');
-			args.push(path.resolve(context.extensionPath, 'lsp-0.0.11-executable.jar'));
+			args.push(path.resolve(context.extensionPath, 'lsp-0.0.12-executable.jar'));
 			args.push(`--PORT=${port.toString()}`);
 
 			let process = child_process.spawn(javaExecutablePath, args, options);

diff --git a/lsp-0.0.11-executable.jar → lsp-0.0.12-executable.jar b/lsp-0.0.11-executable.jar → lsp-0.0.12-executable.jar
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "displayName": "SLDS Validator",
   "publisher": "salesforce",
   "description": "Salesforce Lightning Design System",
-  "version": "1.4.6",
+  "version": "1.4.7",
   "aiKey": "7344b284-73e5-420e-b680-73333da3e067",
   "icon": "images/slds-icon.png",
   "preview": true,
@@ -72,6 +72,11 @@
           "type": "boolean",
           "default": true,
           "description": "Enable or disable invalid SLDS utility classes detection"
+        },
+        "salesforcedx-vscode-slds.basic.mobileValidation": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enable or disable SLDS validation for mobile"
         }
       }
     },
@@ -165,6 +170,16 @@
         "command": "slds.disable:scope",
         "title": "Do not scope SLDS Validator to SFDX project files",
         "category": "SLDS"
+      },
+      {
+        "command": "slds.enable:mobileValidation",
+        "title": "Enable SLDS validation for mobile",
+        "category": "SLDS"
+      },
+      {
+        "command": "slds.disable:mobileValidation",
+        "title": "Disable SLDS validation for mobile",
+        "category": "SLDS"
       }
     ],
     "languages": [