@W-16971261 Create publishing workflow #134
Conversation
|
Hi @clayparksfdc this is showing the workflow file as empty? |
There was a problem hiding this comment.
Hi @clayparksfdc, just a couple tweaks and then some suggestions around adding a trigger for pull_request. I'm happy to pair up and run through my thoughts around that.
workflows/publishVSCode.yml
Outdated
| @@ -0,0 +1,47 @@ | |||
| name: Publish VSCode Extension | |||
There was a problem hiding this comment.
This file should live in .github/workflows/
workflows/publishVSCode.yml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' |
There was a problem hiding this comment.
it doesn't look like we have .nvmrc in CVS, so let's specify a version
| node-version-file: '.nvmrc' | |
| node-version: 'latest' |
workflows/publishVSCode.yml
Outdated
| release: | ||
| types: [created] |
There was a problem hiding this comment.
| release: | |
| types: [created] | |
| release: | |
| types: [released] | |
| pull_request: | |
| branches: [ '**' ] |
the created event type seems a little loose, whereas released will only trigger when the release is for real, not draft or prerelease.
I'm suggesting the pull_request event too in an attempt to create a dry-run/validation for creation of the VSIX file, and we would just add to the conditional in the Publish Extension step to skip is the job is run in a PR.
workflows/publishVSCode.yml
Outdated
| fi | ||
|
|
||
| - name: Publish Extension | ||
| if: success() && steps.package.outputs.VSIX_FILE |
There was a problem hiding this comment.
| if: success() && steps.package.outputs.VSIX_FILE | |
| if: success() && steps.package.outputs.VSIX_FILE && github.event_name == 'release' |
This suggestion is in conjunction with my suggestion of a pull_request trigger
@W-16971261 Create a publishing workflow that publishes based on a new release being created. This utilizes the shared IDX secrets shared with this repository.