Skip to content

Commit

Permalink
chore: pr feedback from first PR
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Jun 17, 2024
1 parent 60ae76c commit 0e27a6c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/sfProject.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const messages = Messages.loadMessages('@salesforce/core', 'config');

const coreMessages = Messages.loadMessages('@salesforce/core', 'core');

/** @deprecated. Use PackageDirDependency from @salesforce/schemas */
export type PackageDirDependency = PackageDirDependencySchema;

type NamedDirAdditions = {
Expand All @@ -44,6 +45,7 @@ type NamedDirAdditions = {
fullPath: string;
};

/** @deprecated. Use PackageDir from @salesforce/schemas */
export type PackageDir = PackageDirSchema;
export type NamedPackagingDir = PackagePackageDir & NamedDirAdditions;
export type NamedPackageDir = PackageDir & NamedDirAdditions;
Expand Down

2 comments on commit 0e27a6c

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 0e27a6c Previous: 60ae76c Ratio
Child logger creation 475808 ops/sec (±0.77%) 479106 ops/sec (±0.48%) 1.01
Logging a string on root logger 789376 ops/sec (±8.56%) 751019 ops/sec (±7.15%) 0.95
Logging an object on root logger 605255 ops/sec (±6.23%) 554338 ops/sec (±7.96%) 0.92
Logging an object with a message on root logger 6189 ops/sec (±208.49%) 10703 ops/sec (±198.75%) 1.73
Logging an object with a redacted prop on root logger 467744 ops/sec (±7.90%) 458888 ops/sec (±11.26%) 0.98
Logging a nested 3-level object on root logger 363830 ops/sec (±6.87%) 345880 ops/sec (±8.18%) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 0e27a6c Previous: 60ae76c Ratio
Child logger creation 327672 ops/sec (±0.85%) 323126 ops/sec (±0.75%) 0.99
Logging a string on root logger 819206 ops/sec (±5.93%) 721665 ops/sec (±5.62%) 0.88
Logging an object on root logger 626163 ops/sec (±6.87%) 590589 ops/sec (±5.42%) 0.94
Logging an object with a message on root logger 4131 ops/sec (±213.62%) 8185 ops/sec (±200.28%) 1.98
Logging an object with a redacted prop on root logger 455776 ops/sec (±10.85%) 482369 ops/sec (±12.23%) 1.06
Logging a nested 3-level object on root logger 330566 ops/sec (±6.20%) 341088 ops/sec (±5.00%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.