refactor: set configs username prop, no mutating

forcedotcom · Oct 11, 2023 · 13dd085 · 13dd085
1 parent a36f946
commit 13dd085
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/org/org.ts b/src/org/org.ts
@@ -798,13 +798,13 @@ export class Org extends AsyncOptionalCreatable<Org.Options> {
     this.logger.debug(`removing username ${authInfo.getFields().username}`);
 
     const orgConfig: OrgUsersConfig = await this.retrieveOrgUsersConfig();
-
-    const contents: ConfigContents = await orgConfig.read();
+    const contents = await orgConfig.read();
 
     const targetUser = authInfo.getFields().username;
-    const usernames = (contents.usernames ?? []) as string[];
-    contents.usernames = usernames.filter((username) => username !== targetUser);
 
+    const usernames = (contents.usernames ?? []).filter((username) => username !== targetUser);
+
+    orgConfig.set('usernames', usernames);
     await orgConfig.write();
     return this;
   }