Skip to content

Commit

Permalink
fix(types): additional props for packaging lib
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Nov 15, 2023
1 parent 41b597d commit 25b3cf1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/sfProject.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ export type PackageDir = {
versionDescription?: string;
versionName?: string;
versionNumber?: string;
unpackagedMetadata?: { path: string };
seedMetadata?: { path: string };
};

export type NamedPackageDir = PackageDir & {
Expand Down

4 comments on commit 25b3cf1

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 25b3cf1 Previous: ff8b066 Ratio
Child logger creation 479149 ops/sec (±1.14%) 492245 ops/sec (±0.48%) 1.03
Logging a string on root logger 789128 ops/sec (±6.99%) 885752 ops/sec (±13.88%) 1.12
Logging an object on root logger 575668 ops/sec (±9.28%) 609807 ops/sec (±7.19%) 1.06
Logging an object with a message on root logger 10577 ops/sec (±201.13%) 25542 ops/sec (±184.23%) 2.41
Logging an object with a redacted prop on root logger 470328 ops/sec (±8.54%) 503837 ops/sec (±8.04%) 1.07
Logging a nested 3-level object on root logger 404392 ops/sec (±7.29%) 25056 ops/sec (±183.14%) 0.06195968268412827

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 25b3cf1 Previous: ff8b066 Ratio
Logging an object with a message on root logger 10577 ops/sec (±201.13%) 25542 ops/sec (±184.23%) 2.41

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 25b3cf1 Previous: ff8b066 Ratio
Child logger creation 345195 ops/sec (±0.47%) 321839 ops/sec (±0.70%) 0.93
Logging a string on root logger 820301 ops/sec (±5.81%) 816003 ops/sec (±5.37%) 0.99
Logging an object on root logger 642427 ops/sec (±5.39%) 535151 ops/sec (±7.75%) 0.83
Logging an object with a message on root logger 3646 ops/sec (±220.41%) 7941 ops/sec (±201.98%) 2.18
Logging an object with a redacted prop on root logger 462167 ops/sec (±7.87%) 493003 ops/sec (±6.01%) 1.07
Logging a nested 3-level object on root logger 331376 ops/sec (±5.16%) 308487 ops/sec (±5.07%) 0.93

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 25b3cf1 Previous: ff8b066 Ratio
Logging an object with a message on root logger 3646 ops/sec (±220.41%) 7941 ops/sec (±201.98%) 2.18

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.