Skip to content

Commit

Permalink
test: not data, yes pdr
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Oct 17, 2023
1 parent 79540e6 commit 2cb98df
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
externalProjectGitUrl:
- https://github.com/salesforcecli/plugin-auth
- https://github.com/salesforcecli/plugin-custom-metadata
- https://github.com/salesforcecli/plugin-data
# - https://github.com/salesforcecli/plugin-data
- https://github.com/salesforcecli/plugin-env
- https://github.com/salesforcecli/plugin-limits
- https://github.com/salesforcecli/plugin-org
Expand All @@ -49,8 +49,21 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ['ubuntu-latest']
os: ['ubuntu-latest', 'windows-latest']
command:
- 'yarn test:nuts:convert'
- 'yarn test:nuts:deb'
- 'yarn test:nuts:delete'
- 'yarn test:nuts:deploy:metadata:manifest'
- 'yarn test:nuts:deploy:metadata:metadata'
- 'yarn test:nuts:deploy:metadata:metadata-dir'
- 'yarn test:nuts:deploy:metadata:source-dir'
- 'yarn test:nuts:deploy:metadata:test-level'
- 'yarn test:nuts:destructive'
- 'yarn test:nuts:manifest'
- 'yarn test:nuts:retrieve'
- 'yarn test:nuts:specialTypes'
- 'yarn test:nuts:static'
- 'yarn test:nuts:tracking'
with:
packageName: '@salesforce/core'
Expand Down

3 comments on commit 2cb98df

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 2cb98df Previous: 79540e6 Ratio
Child logger creation 407642 ops/sec (±10.55%) 534454 ops/sec (±0.23%) 1.31
Logging a string on root logger 476654 ops/sec (±11.48%) 487043 ops/sec (±11.20%) 1.02
Logging an object on root logger 283455 ops/sec (±22.96%) 318013 ops/sec (±16.25%) 1.12
Logging an object with a message on root logger 185635 ops/sec (±19.98%) 256749 ops/sec (±14.14%) 1.38
Logging an object with a redacted prop on root logger 208426 ops/sec (±16.99%) 14024 ops/sec (±185.33%) 0.0672852715112318
Logging a nested 3-level object on root logger 4703 ops/sec (±189.52%) 214674 ops/sec (±15.18%) 45.65

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2cb98df Previous: 79540e6 Ratio
Logging a nested 3-level object on root logger 4703 ops/sec (±189.52%) 214674 ops/sec (±15.18%) 45.65

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 2cb98df Previous: 79540e6 Ratio
Child logger creation 366767 ops/sec (±1.78%) 271109 ops/sec (±22.46%) 0.74
Logging a string on root logger 432725 ops/sec (±17.26%) 238556 ops/sec (±22.03%) 0.55
Logging an object on root logger 282762 ops/sec (±17.24%) 173694 ops/sec (±14.86%) 0.61
Logging an object with a message on root logger 136991 ops/sec (±30.09%) 68388 ops/sec (±68.56%) 0.50
Logging an object with a redacted prop on root logger 162209 ops/sec (±28.06%) 148676 ops/sec (±35.78%) 0.92
Logging a nested 3-level object on root logger 113788 ops/sec (±25.27%) 142859 ops/sec (±16.84%) 1.26

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.