chore: pr comments

forcedotcom · May 29, 2024 · 44d1a33 · 44d1a33 · svc-cli-bot · May 29, 2024
1 parent 1d85289
commit 44d1a33
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/esbuild-publish.yml b/.github/workflows/esbuild-publish.yml
@@ -22,11 +22,15 @@ jobs:
       branch: ${{ inputs.branch }}
       nodeVersion: ${{ inputs.nodeVersion }}
   publish:
+    needs: bundle
     runs-on: ubuntu-latest
     steps:
-    - name: Publish a Package
-      run: |
-        npm config set //registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN
-        npm publish
-      env:
-        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ inputs.branch }}
+      - name: Publish a Package
+        run: |
+          npm config set //registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN
+          npm publish
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/testExternalProjects.yml b/.github/workflows/testExternalProjects.yml
@@ -85,6 +85,3 @@ jobs:
           max_attempts: ${{ inputs.attempts }}
           command: yarn test
           retry_on: error
-        env:
-          SF_DISABLE_TELEMETRY: true
-          DEBUG: ${{ vars.DEBUG }}
Benchmark suite	Current: `44d1a33`	Previous: `1e09e45`	Ratio
`Child logger creation`	`481575` ops/sec (`±1.30%`)	`468087` ops/sec (`±2.46%`)	`0.97`
`Logging a string on root logger`	`804616` ops/sec (`±6.06%`)	`845364` ops/sec (`±8.24%`)	`1.05`
`Logging an object on root logger`	`671351` ops/sec (`±7.76%`)	`605865` ops/sec (`±7.46%`)	`0.90`
`Logging an object with a message on root logger`	`2751` ops/sec (`±242.66%`)	`3194` ops/sec (`±234.56%`)	`1.16`
`Logging an object with a redacted prop on root logger`	`447269` ops/sec (`±8.17%`)	`375262` ops/sec (`±24.96%`)	`0.84`
`Logging a nested 3-level object on root logger`	`364479` ops/sec (`±7.19%`)	`379263` ops/sec (`±6.86%`)	`1.04`
Benchmark suite	Current: `44d1a33`	Previous: `1e09e45`	Ratio
`Child logger creation`	`325915` ops/sec (`±0.72%`)	`305769` ops/sec (`±2.10%`)	`0.94`
`Logging a string on root logger`	`773113` ops/sec (`±5.38%`)	`752376` ops/sec (`±6.36%`)	`0.97`
`Logging an object on root logger`	`578832` ops/sec (`±6.19%`)	`536686` ops/sec (`±7.72%`)	`0.93`
`Logging an object with a message on root logger`	`5579` ops/sec (`±205.39%`)	`9080` ops/sec (`±199.22%`)	`1.63`
`Logging an object with a redacted prop on root logger`	`488864` ops/sec (`±6.25%`)	`433736` ops/sec (`±12.27%`)	`0.89`
`Logging a nested 3-level object on root logger`	`345643` ops/sec (`±5.03%`)	`337251` ops/sec (`±5.42%`)	`0.98`