Skip to content

Commit

Permalink
chore: revert test
Browse files Browse the repository at this point in the history
  • Loading branch information
@iowillhoit
iowillhoit committed Jul 9, 2024
1 parent 4989731 commit 4c52010
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/unit/messagesTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ describe('Messages', () => {

it('should return single string from array of messages', () => {
expect(messages.getMessage('manyMsgs', ['blah', 864])).to.equal(
`hello${EOL}world${EOL}test message 2 blah and 864`
`hello blah 864${EOL}world blah 864${EOL}test message 2 blah and 864`
);
});

it('should return multiple string from array of messages', () => {
expect(messages.getMessages('manyMsgs', ['blah', 864])).to.deep.equal([
'hello',
'world',
'hello blah 864',
'world blah 864',
'test message 2 blah and 864',
]);
});
Expand Down

3 comments on commit 4c52010

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 4c52010 Previous: ceb7cbd Ratio
Child logger creation 479404 ops/sec (±0.90%) 467786 ops/sec (±2.51%) 0.98
Logging a string on root logger 740650 ops/sec (±11.34%) 713866 ops/sec (±6.52%) 0.96
Logging an object on root logger 606027 ops/sec (±10.17%) 518093 ops/sec (±8.79%) 0.85
Logging an object with a message on root logger 6536 ops/sec (±209.05%) 15000 ops/sec (±188.77%) 2.29
Logging an object with a redacted prop on root logger 408875 ops/sec (±9.44%) 460859 ops/sec (±8.91%) 1.13
Logging a nested 3-level object on root logger 377359 ops/sec (±6.06%) 353060 ops/sec (±5.65%) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 4c52010 Previous: ceb7cbd Ratio
Logging an object with a message on root logger 6536 ops/sec (±209.05%) 15000 ops/sec (±188.77%) 2.29

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 4c52010 Previous: ceb7cbd Ratio
Child logger creation 314465 ops/sec (±0.95%) 320268 ops/sec (±0.89%) 1.02
Logging a string on root logger 763090 ops/sec (±9.00%) 803241 ops/sec (±5.63%) 1.05
Logging an object on root logger 628284 ops/sec (±8.94%) 584711 ops/sec (±5.93%) 0.93
Logging an object with a message on root logger 4485 ops/sec (±213.49%) 6114 ops/sec (±205.43%) 1.36
Logging an object with a redacted prop on root logger 407848 ops/sec (±16.46%) 445908 ops/sec (±13.82%) 1.09
Logging a nested 3-level object on root logger 313828 ops/sec (±6.09%) 321399 ops/sec (±4.85%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.