chore: no cache for perf tests

forcedotcom · Jun 7, 2024 · 4e697cd · 4e697cd · svc-cli-bot · Jun 7, 2024
1 parent 82fee15
commit 4e697cd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml
@@ -19,8 +19,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
-        with:
-          cache: yarn
       - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
         with:
           ignore-scripts: true

diff --git a/src/sfProject.ts b/src/sfProject.ts
@@ -725,7 +725,7 @@ export class SfProject {
   }
 }
 
-/** differentiate between the Base PackageDir (path, maybe default) and the Packaging version (path) by whether is has the `package` property */
+/** differentiate between the Base PackageDir (path, maybe default) and the Packaging version (package and maybe a LOT of other fields) by whether is has the `package` property */
 export const isPackagingDirectory = (packageDir: PackageDir): packageDir is PackagePackageDir =>
   'package' in packageDir && typeof packageDir.package === 'string';
 export const isNamedPackagingDirectory = (packageDir: NamedPackageDir): packageDir is NamedPackagingDir =>
Benchmark suite	Current: `4e697cd`	Previous: `82fee15`	Ratio
`Child logger creation`	`469254` ops/sec (`±0.57%`)	`479686` ops/sec (`±1.90%`)	`1.02`
`Logging a string on root logger`	`831676` ops/sec (`±8.24%`)	`833111` ops/sec (`±10.23%`)	`1.00`
`Logging an object on root logger`	`624083` ops/sec (`±8.95%`)	`629697` ops/sec (`±6.43%`)	`1.01`
`Logging an object with a message on root logger`	`3277` ops/sec (`±234.93%`)	`1938` ops/sec (`±255.72%`)	`0.59`
`Logging an object with a redacted prop on root logger`	`428759` ops/sec (`±9.65%`)	`446902` ops/sec (`±10.27%`)	`1.04`
`Logging a nested 3-level object on root logger`	`390398` ops/sec (`±8.03%`)	`384443` ops/sec (`±8.89%`)	`0.98`
Benchmark suite	Current: `4e697cd`	Previous: `82fee15`	Ratio
`Child logger creation`	`329984` ops/sec (`±0.78%`)	`323617` ops/sec (`±1.03%`)	`0.98`
`Logging a string on root logger`	`801521` ops/sec (`±5.09%`)	`828942` ops/sec (`±6.68%`)	`1.03`
`Logging an object on root logger`	`565751` ops/sec (`±9.07%`)	`626486` ops/sec (`±5.04%`)	`1.11`
`Logging an object with a message on root logger`	`6053` ops/sec (`±205.20%`)	`19580` ops/sec (`±185.13%`)	`3.23`
`Logging an object with a redacted prop on root logger`	`421431` ops/sec (`±11.19%`)	`479325` ops/sec (`±7.16%`)	`1.14`
`Logging a nested 3-level object on root logger`	`327142` ops/sec (`±5.44%`)	`325845` ops/sec (`±4.93%`)	`1.00`