Skip to content

Commit

Permalink
test: remove core from more libraries to force this version
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Oct 18, 2023
1 parent 1f85774 commit 60bfafd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
os: ${{ matrix.os }}
useCache: false
preSwapCommands: 'yarn upgrade [email protected]; npx yarn-deduplicate; yarn install'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core'
secrets: inherit
# hidden until we fix source-testkit to better handle jwt
deployRetrieveNuts:
Expand Down Expand Up @@ -71,6 +71,6 @@ jobs:
preSwapCommands: 'yarn upgrade [email protected]; npx yarn-deduplicate; yarn install'
command: ${{ matrix.command }}
os: ${{ matrix.os }}
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core'
preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/jsforce shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core'
secrets:
TESTKIT_AUTH_URL: ${{ secrets.TESTKIT_AUTH_URL }}

3 comments on commit 60bfafd

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 60bfafd Previous: c03ec4d Ratio
Child logger creation 439957 ops/sec (±4.05%) 527923 ops/sec (±0.56%) 1.20
Logging a string on root logger 451881 ops/sec (±15.17%) 520436 ops/sec (±9.55%) 1.15
Logging an object on root logger 254038 ops/sec (±11.54%) 350764 ops/sec (±15.59%) 1.38
Logging an object with a message on root logger 196574 ops/sec (±10.05%) 218992 ops/sec (±16.76%) 1.11
Logging an object with a redacted prop on root logger 237540 ops/sec (±13.68%) 10976 ops/sec (±194.88%) 0.04620695461816957
Logging a nested 3-level object on root logger 7037 ops/sec (±187.21%) 171810 ops/sec (±39.14%) 24.42

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 60bfafd Previous: c03ec4d Ratio
Logging a nested 3-level object on root logger 7037 ops/sec (±187.21%) 171810 ops/sec (±39.14%) 24.42

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 60bfafd Previous: c03ec4d Ratio
Child logger creation 360011 ops/sec (±9.42%) 487123 ops/sec (±5.77%) 1.35
Logging a string on root logger 438491 ops/sec (±9.03%) 598100 ops/sec (±9.40%) 1.36
Logging an object on root logger 331694 ops/sec (±12.37%) 297384 ops/sec (±24.03%) 0.90
Logging an object with a message on root logger 218893 ops/sec (±15.88%) 129528 ops/sec (±25.79%) 0.59
Logging an object with a redacted prop on root logger 238278 ops/sec (±17.12%) 197146 ops/sec (±20.30%) 0.83
Logging a nested 3-level object on root logger 173777 ops/sec (±17.96%) 135313 ops/sec (±19.35%) 0.78

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.