Skip to content

Commit

Permalink
chore
Browse files Browse the repository at this point in the history
  • Loading branch information
mingxuanzhangsfdx committed Jul 31, 2024
1 parent a2fac56 commit 7f11ab8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/testCoreBundling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
matrix:
os: ['ubuntu-latest', 'windows-latest']
externalProjectGit:
- forcedotcom/salesforcedx-templates
- forcedotcom/salesforcedx-apex
with:
externalProjectGit: ${{ matrix.externalProjectGit }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testExternalProjects.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_call:
inputs:
externalProjectGit:
description: 'The url that will be cloned. This contains the tests you want to run. Ex: https://github.com/forcedotcom/templates'
description: 'The url that will be cloned. This contains the tests you want to run. Ex: https://github.com/forcedotcom/salesforcedx-apex'
type: string
required: true
nodeVersion:
Expand All @@ -29,7 +29,7 @@ on:
jobs:
external-test:
name: run tests
if: ${{ inputs.externalProjectGit == 'forcedotcom/salesforcedx-apex' || (inputs.externalProjectGit == 'forcedotcom/salesforcedx-templates' && inputs.os == 'ubuntu-latest') }}
if: ${{ inputs.externalProjectGit == 'forcedotcom/salesforcedx-apex' }}
runs-on: ${{ inputs.os }}
steps:
- name: Configure Git to handle long file paths on Windows
Expand Down

3 comments on commit 7f11ab8

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 7f11ab8 Previous: 57371d6 Ratio
Child logger creation 477448 ops/sec (±1.60%) 476864 ops/sec (±1.32%) 1.00
Logging a string on root logger 861771 ops/sec (±9.20%) 837381 ops/sec (±9.25%) 0.97
Logging an object on root logger 648557 ops/sec (±6.14%) 650257 ops/sec (±6.72%) 1.00
Logging an object with a message on root logger 13671 ops/sec (±188.90%) 2341 ops/sec (±242.97%) 0.17
Logging an object with a redacted prop on root logger 526707 ops/sec (±9.21%) 458356 ops/sec (±7.26%) 0.87
Logging a nested 3-level object on root logger 22576 ops/sec (±185.31%) 371205 ops/sec (±7.97%) 16.44

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7f11ab8 Previous: 57371d6 Ratio
Logging a nested 3-level object on root logger 22576 ops/sec (±185.31%) 371205 ops/sec (±7.97%) 16.44

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 7f11ab8 Previous: 57371d6 Ratio
Child logger creation 307575 ops/sec (±1.53%) 320250 ops/sec (±1.14%) 1.04
Logging a string on root logger 724299 ops/sec (±6.74%) 731820 ops/sec (±6.24%) 1.01
Logging an object on root logger 571246 ops/sec (±5.94%) 614926 ops/sec (±6.44%) 1.08
Logging an object with a message on root logger 8846 ops/sec (±191.32%) 8894 ops/sec (±198.81%) 1.01
Logging an object with a redacted prop on root logger 469364 ops/sec (±5.74%) 430493 ops/sec (±12.22%) 0.92
Logging a nested 3-level object on root logger 322796 ops/sec (±5.88%) 308581 ops/sec (±5.94%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.