Skip to content

Commit

Permalink
feat!: remove SchemaPrinter
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Oct 19, 2023
1 parent b184d51 commit 903fc59
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 310 deletions.
1 change: 0 additions & 1 deletion src/exported.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export { OrgConfigProperties, ORG_CONFIG_ALLOWED_PROPERTIES } from './org/orgCon
export { PackageDir, NamedPackageDir, PackageDirDependency, SfProject, SfProjectJson } from './sfProject';

export { SchemaValidator } from './schema/validator';
export { SchemaPrinter } from './schema/printer';

export { SfError } from './sfError';

Expand Down
309 changes: 0 additions & 309 deletions src/schema/printer.ts

This file was deleted.

3 comments on commit 903fc59

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 903fc59 Previous: f1f20a6 Ratio
Child logger creation 550548 ops/sec (±0.54%) 499026 ops/sec (±1.37%) 0.91
Logging a string on root logger 620694 ops/sec (±9.50%) 646407 ops/sec (±8.13%) 1.04
Logging an object on root logger 409332 ops/sec (±10.85%) 350076 ops/sec (±16.11%) 0.86
Logging an object with a message on root logger 285993 ops/sec (±15.73%) 202793 ops/sec (±16.95%) 0.71
Logging an object with a redacted prop on root logger 8805 ops/sec (±200.83%) 231853 ops/sec (±18.69%) 26.33
Logging a nested 3-level object on root logger 260990 ops/sec (±16.37%) 7661 ops/sec (±187.53%) 0.029353615081037586

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 903fc59 Previous: f1f20a6 Ratio
Logging an object with a redacted prop on root logger 8805 ops/sec (±200.83%) 231853 ops/sec (±18.69%) 26.33

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 903fc59 Previous: f1f20a6 Ratio
Child logger creation 498393 ops/sec (±0.53%) 211194 ops/sec (±113.76%) 0.42
Logging a string on root logger 555831 ops/sec (±12.68%) 613401 ops/sec (±11.43%) 1.10
Logging an object on root logger 309338 ops/sec (±20.04%) 347661 ops/sec (±26.61%) 1.12
Logging an object with a message on root logger 157406 ops/sec (±21.40%) 261759 ops/sec (±16.12%) 1.66
Logging an object with a redacted prop on root logger 174440 ops/sec (±20.57%) 270645 ops/sec (±22.51%) 1.55
Logging a nested 3-level object on root logger 145018 ops/sec (±18.82%) 983 ops/sec (±276.76%) 0.006778468879725275

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.