Skip to content

Commit

Permalink
fix: backward logic on scratch/sbox
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Dec 4, 2023
1 parent 8903d46 commit 98762d5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/org/org.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,8 @@ export class Org extends AsyncOptionalCreatable<Org.Options> {
[Org.Fields.NAME]: organization.Name,
[Org.Fields.INSTANCE_NAME]: organization.InstanceName,
[Org.Fields.NAMESPACE_PREFIX]: organization.NamespacePrefix,
[Org.Fields.IS_SANDBOX]: organization.IsSandbox && Boolean(organization.TrialExpirationDate),
[Org.Fields.IS_SCRATCH]: organization.IsSandbox && !organization.TrialExpirationDate,
[Org.Fields.IS_SANDBOX]: organization.IsSandbox && !organization.TrialExpirationDate,
[Org.Fields.IS_SCRATCH]: organization.IsSandbox && Boolean(organization.TrialExpirationDate),
[Org.Fields.TRIAL_EXPIRATION_DATE]: organization.TrialExpirationDate,
};
const stateAggregator = await StateAggregator.getInstance();
Expand Down

3 comments on commit 98762d5

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 98762d5 Previous: 22eb1c6 Ratio
Child logger creation 510994 ops/sec (±2.48%) 464376 ops/sec (±2.68%) 0.91
Logging a string on root logger 896263 ops/sec (±7.43%) 857759 ops/sec (±8.79%) 0.96
Logging an object on root logger 46001 ops/sec (±182.22%) 570402 ops/sec (±10.30%) 12.40
Logging an object with a message on root logger 440955 ops/sec (±9.31%) 1861 ops/sec (±276.51%) 0.00422038530008731
Logging an object with a redacted prop on root logger 514060 ops/sec (±7.93%) 467758 ops/sec (±6.45%) 0.91
Logging a nested 3-level object on root logger 22320 ops/sec (±185.80%) 374784 ops/sec (±11.25%) 16.79

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 98762d5 Previous: 22eb1c6 Ratio
Logging an object on root logger 46001 ops/sec (±182.22%) 570402 ops/sec (±10.30%) 12.40
Logging a nested 3-level object on root logger 22320 ops/sec (±185.80%) 374784 ops/sec (±11.25%) 16.79

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 98762d5 Previous: 22eb1c6 Ratio
Child logger creation 321623 ops/sec (±0.79%) 343465 ops/sec (±0.58%) 1.07
Logging a string on root logger 794560 ops/sec (±6.31%) 825125 ops/sec (±6.80%) 1.04
Logging an object on root logger 611766 ops/sec (±6.48%) 630376 ops/sec (±6.05%) 1.03
Logging an object with a message on root logger 3707 ops/sec (±215.43%) 3851 ops/sec (±217.92%) 1.04
Logging an object with a redacted prop on root logger 472310 ops/sec (±12.10%) 468673 ops/sec (±6.55%) 0.99
Logging a nested 3-level object on root logger 337069 ops/sec (±6.29%) 337094 ops/sec (±5.28%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.