Skip to content

Commit

Permalink
fix: add scopeProfiles to project type
Browse files Browse the repository at this point in the history
  • Loading branch information
shetzel committed Oct 9, 2023
1 parent efc977a commit b130982
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/sfProject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export type PackageDir = {
postInstallScript?: string;
postInstallUrl?: string;
releaseNotesUrl?: string;
scopeProfiles?: boolean;
uninstallScript?: string;
versionDescription?: string;
versionName?: string;
Expand Down

3 comments on commit b130982

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: b130982 Previous: 08fb56b Ratio
Child logger creation 496739 ops/sec (±0.72%) 467001 ops/sec (±1.22%) 0.94
Logging a string on root logger 562212 ops/sec (±10.08%) 426465 ops/sec (±10.17%) 0.76
Logging an object on root logger 187599 ops/sec (±106.83%) 302544 ops/sec (±10.85%) 1.61
Logging an object with a message on root logger 253494 ops/sec (±11.05%) 232860 ops/sec (±12.46%) 0.92
Logging an object with a redacted prop on root logger 5702 ops/sec (±208.30%) 229127 ops/sec (±11.15%) 40.18
Logging a nested 3-level object on root logger 225990 ops/sec (±7.37%) 5783 ops/sec (±199.01%) 0.025589627859639807

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b130982 Previous: 08fb56b Ratio
Logging an object with a redacted prop on root logger 5702 ops/sec (±208.30%) 229127 ops/sec (±11.15%) 40.18

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: b130982 Previous: 08fb56b Ratio
Child logger creation 511254 ops/sec (±1.49%) 584160 ops/sec (±8.99%) 1.14
Logging a string on root logger 612462 ops/sec (±9.92%) 854197 ops/sec (±9.95%) 1.39
Logging an object on root logger 384381 ops/sec (±14.10%) 488276 ops/sec (±20.09%) 1.27
Logging an object with a message on root logger 293185 ops/sec (±16.58%) 246106 ops/sec (±25.78%) 0.84
Logging an object with a redacted prop on root logger 12328 ops/sec (±187.36%) 3584 ops/sec (±241.56%) 0.29
Logging a nested 3-level object on root logger 269635 ops/sec (±8.62%) 309153 ops/sec (±13.16%) 1.15

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.