Skip to content

Commit

Permalink
chore: remove transport to see if it is a bottleneck
Browse files Browse the repository at this point in the history
  • Loading branch information
mingxuanzhangsfdx committed Dec 8, 2023
1 parent 9c56a07 commit ce61345
Show file tree
Hide file tree
Showing 3 changed files with 15,971 additions and 15,978 deletions.
1 change: 1 addition & 0 deletions dist/exported.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2155,6 +2155,7 @@ declare module '@salesforce/core/logger/logger' {
*/
fatal(...args: unknown[]): Logger;
}
/** return various streams that the logger could send data to, depending on the options and env */
export const computeLevel: (optionsLevel?: number | string) => string;
}
declare module '@salesforce/core/logger/memoryLogger' {
Expand Down
Loading

4 comments on commit ce61345

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: ce61345 Previous: 43e0739 Ratio
Child logger creation 481877 ops/sec (±1.02%) 481077 ops/sec (±0.72%) 1.00
Logging a string on root logger 156931 ops/sec (±0.37%) 749309 ops/sec (±7.93%) 4.77
Logging an object on root logger 153312 ops/sec (±1.14%) 557452 ops/sec (±7.90%) 3.64
Logging an object with a message on root logger 117395 ops/sec (±4.44%) 13357 ops/sec (±197.27%) 0.11
Logging an object with a redacted prop on root logger 143243 ops/sec (±0.56%) 430078 ops/sec (±9.20%) 3.00
Logging a nested 3-level object on root logger 112886 ops/sec (±0.55%) 355432 ops/sec (±8.07%) 3.15

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ce61345 Previous: 43e0739 Ratio
Logging a string on root logger 156931 ops/sec (±0.37%) 749309 ops/sec (±7.93%) 4.77
Logging an object on root logger 153312 ops/sec (±1.14%) 557452 ops/sec (±7.90%) 3.64
Logging an object with a redacted prop on root logger 143243 ops/sec (±0.56%) 430078 ops/sec (±9.20%) 3.00
Logging a nested 3-level object on root logger 112886 ops/sec (±0.55%) 355432 ops/sec (±8.07%) 3.15

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: ce61345 Previous: 43e0739 Ratio
Child logger creation 323746 ops/sec (±1.07%) 326171 ops/sec (±0.72%) 1.01
Logging a string on root logger 137875 ops/sec (±0.61%) 697714 ops/sec (±6.14%) 5.06
Logging an object on root logger 131238 ops/sec (±0.68%) 536010 ops/sec (±5.45%) 4.08
Logging an object with a message on root logger 99977 ops/sec (±5.62%) 15124 ops/sec (±186.66%) 0.15
Logging an object with a redacted prop on root logger 126415 ops/sec (±0.83%) 417471 ops/sec (±9.10%) 3.30
Logging a nested 3-level object on root logger 96629 ops/sec (±0.94%) 320087 ops/sec (±6.80%) 3.31

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ce61345 Previous: 43e0739 Ratio
Logging a string on root logger 137875 ops/sec (±0.61%) 697714 ops/sec (±6.14%) 5.06
Logging an object on root logger 131238 ops/sec (±0.68%) 536010 ops/sec (±5.45%) 4.08
Logging an object with a redacted prop on root logger 126415 ops/sec (±0.83%) 417471 ops/sec (±9.10%) 3.30
Logging a nested 3-level object on root logger 96629 ops/sec (±0.94%) 320087 ops/sec (±6.80%) 3.31

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.